Change all bare catch blocks to handle specific relevant exceptions (#1328)

* Initial plan

* Fix all bare catch blocks with specific exception types

Co-authored-by: leculver <[email protected]>

* Address PR feedback: use try/finally pattern in DataTarget.cs and revert global.json

Co-authored-by: leculver <[email protected]>

* Add missing System.IO imports for IOException and InvalidDataException

Co-authored-by: leculver <[email protected]>

* Add missing System.IO import for IOException and InvalidDataException in ResourceEntry.cs

Co-authored-by: leculver <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: leculver <[email protected]>

Author: Copilot

src/Microsoft.Diagnostics.Runtime/ClrModule.cs

@@ -5,6 +5,7 @@
 using System.Buffers;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.IO;
 using System.Linq;
 using System.Threading;
 
@@ -268,7 +269,7 @@ private ulong GetSize()
                     }
                 }
             }
-            catch
+            catch (Exception ex) when (ex is IOException or ArgumentException or OutOfMemoryException or InvalidDataException or ObjectDisposedException)
             {
             }
 

src/Microsoft.Diagnostics.Runtime/ClrRuntime.cs

@@ -466,7 +466,7 @@ private DomainAndModules InitAppDomainData()
                             if (fileName.Equals(bclName, StringComparison.OrdinalIgnoreCase))
                                 bcl = module;
                         }
-                        catch
+                        catch (Exception ex) when (ex is ArgumentException or IOException or NotSupportedException)
                         {
                         }
                     }

src/Microsoft.Diagnostics.Runtime/DataReaders/LinuxSnapshot/LinuxSnapshotTarget.cs

@@ -27,7 +27,7 @@ protected override void Dispose(bool disposing)
             {
                 File.Delete(_filename);
             }
-            catch
+            catch (Exception ex) when (ex is IOException or UnauthorizedAccessException or ArgumentException or NotSupportedException)
             {
             }
         }

src/Microsoft.Diagnostics.Runtime/DataTarget.cs

@@ -281,6 +281,7 @@ public IEnumerable<ModuleInfo> EnumerateModules()
         /// <returns>A <see cref="DataTarget"/> for the given dump.</returns>
         public static DataTarget LoadDump(string displayName, Stream stream, CacheOptions? cacheOptions = null, bool leaveOpen = false, TokenCredential? symbolCredential = null)
         {
+            bool success = false;
             try
             {
                 if (displayName is null)
@@ -313,13 +314,14 @@ public static DataTarget LoadDump(string displayName, Stream stream, CacheOption
                     _ => throw new InvalidDataException($"Stream '{displayName}' is in an unknown or unsupported file format."),
                 };
 
-                return new DataTarget(new CustomDataTarget(reader, symbolCredential) { CacheOptions = cacheOptions });
+                DataTarget result = new DataTarget(new CustomDataTarget(reader, symbolCredential) { CacheOptions = cacheOptions });
+                success = true;
+                return result;
             }
-            catch
+            finally
             {
-                if (!leaveOpen)
+                if (!success && !leaveOpen)
                     stream?.Dispose();
-                throw;
             }
         }
 

src/Microsoft.Diagnostics.Runtime/GCRoot.cs

@@ -81,7 +81,7 @@ private void WorkerThread(CancellationToken token, BlockingCollection<ClrRoot> q
                     queue.Add(root);
                 }
             }
-            catch
+            catch (Exception ex) when (ex is InvalidOperationException or ObjectDisposedException or ArgumentException)
             {
             }
             finally

src/Microsoft.Diagnostics.Runtime/Implementation/DotNetClrInfoProvider.cs

@@ -240,7 +240,7 @@ protected ClrInfo CreateClrInfo(DataTarget dataTarget, ModuleInfo module, ulong
                                     }
                                 }
                             }
-                            catch
+                            catch (Exception ex) when (ex is IOException or UnauthorizedAccessException or ArgumentException or NotSupportedException)
                             {
                             }
                         }

src/Microsoft.Diagnostics.Runtime/Implementation/PEModuleInfo.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
+using System.IO;
 using System.Threading;
 using Microsoft.Diagnostics.Runtime.Utilities;
 
@@ -49,7 +50,7 @@ internal sealed class PEModuleInfo : ModuleInfo
 
                 image.Dispose();
             }
-            catch
+            catch (Exception ex) when (ex is IOException or ArgumentException or OutOfMemoryException or InvalidDataException or ObjectDisposedException)
             {
             }
 

src/Microsoft.Diagnostics.Runtime/ModuleInfo.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Immutable;
+using System.IO;
 using System.Linq;
 using System.Runtime.CompilerServices;
 using Microsoft.Diagnostics.Runtime.Implementation;
@@ -54,7 +55,7 @@ public abstract class ModuleInfo
                     return new MacOS.MachOModuleInfo(module, baseAddress, name, null, module.ImageSize);
                 }
             }
-            catch
+            catch (Exception ex) when (ex is InvalidDataException or IOException or ArgumentException or OverflowException or OutOfMemoryException)
             {
                 // We could encounter any number of errors in the Elf/Mach-O system, we will just ignore them here.
             }

src/Microsoft.Diagnostics.Runtime/Utilities/PEImage/ResourceEntry.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Buffers;
 using System.Collections.Immutable;
+using System.IO;
 using System.Linq;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
@@ -165,7 +166,7 @@ public ImmutableArray<IResourceNode> Children
 
                     return _children = result.MoveOrCopyToImmutable();
                 }
-                catch
+                catch (Exception ex) when (ex is OutOfMemoryException or OverflowException or InvalidDataException or ArgumentException or IOException)
                 {
                     // If there's a bad image we could hit a variety of different failures here, including out of memory or
                     // under/overflow issues.  We'll just not return anything if we hit an error here since a bad image