You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
classifier-reborn is designed to work with or without
[GSL](https://www.gnu.org/software/gsl/) support.
https://github.com/jekyll/classifier-reborn/blob/99d13af5adf040ba40a6fe77dbe0b28756562fcc/docs/index.md?plain=1#L68
If GSL is installed, classifier-reborn will detect it and use it. If GSL
is not installed, classifier-reborn will fall back to a pure-ruby
implementation. The mechanism for doing so is in `lsi.rb`:
https://github.com/jekyll/classifier-reborn/blob/99d13af5adf040ba40a6fe77dbe0b28756562fcc/lib/classifier-reborn/lsi.rb#L7-L17
Notably, there's a comment there about how to test with/without GSL
enabled.
> to test the native vector class, try `rake test NATIVE_VECTOR=true`
As far as I can tell, this was only ever used for local
development/testing, and was never tested in CI (though adding GSL
testing to CI was previously discussed
[here](jekyll#46 (comment))).
I did not include this in my last PR (jekyll#195) because I was focused on
porting existing testing functionality from TravisCI to GitHub Actions.
Now that GitHub Actions is working, I think it's important to expand our
CI coverage to test with and without GSL in CI. So, in this PR, I'm
doing so by setting `NATIVE_VECTOR` to true or false in our test matrix
and installing the required `libgsl-dev` package in the Ubuntu test
environment.
While working on this, I noticed some tests in the LSI spec that return
early when `$GSL` is not enabled. It would be better for those tests to
report as skipped when GSL is not enabled (and this matches the pattern
of the redis tests, that report as skipped if redis isn't available).
0 commit comments