From 7d5bb1500f3652ea491a5de992639989347ff1b9 Mon Sep 17 00:00:00 2001 From: Sam Spencer Date: Wed, 2 Apr 2025 13:35:03 -0700 Subject: [PATCH 1/2] Changed the name of the ActivitySource and Metric to clarify that the semantic conventions have not been ratified yet. --- src/ModelContextProtocol/Diagnostics.cs | 4 ++-- tests/ModelContextProtocol.Tests/DiagnosticTests.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ModelContextProtocol/Diagnostics.cs b/src/ModelContextProtocol/Diagnostics.cs index a85aa064..7e37b5a9 100644 --- a/src/ModelContextProtocol/Diagnostics.cs +++ b/src/ModelContextProtocol/Diagnostics.cs @@ -5,7 +5,7 @@ namespace ModelContextProtocol; internal static class Diagnostics { - internal static ActivitySource ActivitySource { get; } = new("ModelContextProtocol"); + internal static ActivitySource ActivitySource { get; } = new("Exprimental.ModelContextProtocol"); /// /// Follows boundaries from http.server.request.duration/http.client.request.duration @@ -24,6 +24,6 @@ internal static class Diagnostics HistogramBucketBoundaries = [0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30, 60, 120, 300], }; - internal static Meter Meter { get; } = new("ModelContextProtocol"); + internal static Meter Meter { get; } = new("Experimental.ModelContextProtocol"); } diff --git a/tests/ModelContextProtocol.Tests/DiagnosticTests.cs b/tests/ModelContextProtocol.Tests/DiagnosticTests.cs index 24c5430e..583ae274 100644 --- a/tests/ModelContextProtocol.Tests/DiagnosticTests.cs +++ b/tests/ModelContextProtocol.Tests/DiagnosticTests.cs @@ -17,7 +17,7 @@ public async Task Session_TracksActivities() var activities = new List(); using (var tracerProvider = OpenTelemetry.Sdk.CreateTracerProviderBuilder() - .AddSource("ModelContextProtocol") + .AddSource("Experimental.ModelContextProtocol") .AddInMemoryExporter(activities) .Build()) { From d67cc4cca7c54c94d7f62f38c3429af4309496db Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Wed, 2 Apr 2025 16:49:41 -0400 Subject: [PATCH 2/2] Update src/ModelContextProtocol/Diagnostics.cs --- src/ModelContextProtocol/Diagnostics.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ModelContextProtocol/Diagnostics.cs b/src/ModelContextProtocol/Diagnostics.cs index 7e37b5a9..c8845228 100644 --- a/src/ModelContextProtocol/Diagnostics.cs +++ b/src/ModelContextProtocol/Diagnostics.cs @@ -5,7 +5,7 @@ namespace ModelContextProtocol; internal static class Diagnostics { - internal static ActivitySource ActivitySource { get; } = new("Exprimental.ModelContextProtocol"); + internal static ActivitySource ActivitySource { get; } = new("Experimental.ModelContextProtocol"); /// /// Follows boundaries from http.server.request.duration/http.client.request.duration