From 758c0b52cda8475c78fbd9b5219f31b37559ee02 Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Tue, 8 Apr 2025 23:23:35 -0700 Subject: [PATCH 1/6] Update markdown-link-check to ignore external links causing 403 in CI --- .github/workflows/markdown-link-check.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index d3fdfeaf..d4b675e2 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -12,5 +12,9 @@ jobs: steps: - name: Checkout uses: actions/checkout@main + - name: Markup Link Checker (mlc) - uses: becheran/mlc@v0.15.4 \ No newline at end of file + uses: becheran/mlc@v0.15.4 + with: + # Ignore external links that result in 403 errors during CI + args: --ignore-links "https://www.anthropic.com/,https://hackerone.com/anthropic-vdp" ./ From b3bb830346285675b3dfe71370537e7a2904ca4e Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Tue, 8 Apr 2025 23:32:03 -0700 Subject: [PATCH 2/6] Apply wildcards on ignored links --- .github/workflows/markdown-link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index d4b675e2..ff570e3a 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -17,4 +17,4 @@ jobs: uses: becheran/mlc@v0.15.4 with: # Ignore external links that result in 403 errors during CI - args: --ignore-links "https://www.anthropic.com/,https://hackerone.com/anthropic-vdp" ./ + args: --ignore-links "http*://www.anthropic.com/*,http*://hackerone.com/anthropic-vdp/*" ./ From e1915fcab125937040c07aed22d48af943e46ea0 Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Tue, 8 Apr 2025 23:34:43 -0700 Subject: [PATCH 3/6] Bump version of mlc to latest to gain --ignore-links arg --- .github/workflows/markdown-link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index ff570e3a..8d6e430d 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -14,7 +14,7 @@ jobs: uses: actions/checkout@main - name: Markup Link Checker (mlc) - uses: becheran/mlc@v0.15.4 + uses: becheran/mlc@v0.21.0 with: # Ignore external links that result in 403 errors during CI args: --ignore-links "http*://www.anthropic.com/*,http*://hackerone.com/anthropic-vdp/*" ./ From 6feae6efbf4d2c3474412136f908f44f95631e10 Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Tue, 8 Apr 2025 23:38:39 -0700 Subject: [PATCH 4/6] Do not warn on redirects from markdown-link-check action --- .github/workflows/release.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.md b/.github/workflows/release.md index 4077944f..834f56b4 100644 --- a/.github/workflows/release.md +++ b/.github/workflows/release.md @@ -31,7 +31,7 @@ The following process is used when publishing new releases to NuGet.org: 3. **Monitor the Release workflow** - After publishing the release, a workflow will begin for producing the release's build artifacts and publishing the NuGet package to NuGet.org - If the job fails, troubleshoot and re-run the workflow as needed - - Verify the package version becomes listed on at [https://nuget.org/packages/ModelContextProtocol](https://nuget.org/packages/ModelContextProtocol) + - Verify the package version becomes listed on at [https://nuget.org/packages/ModelContextProtocol](https://www.nuget.org/packages/ModelContextProtocol) 4. **Update the source to increment the version number** - Immediately after publishing a new release, the [`/src/Directory.Build.Props`](../../src/Directory.Build.props) file needs to be updated to bump the version to the next expected release version From ebd07c820f2b1ed02f30b7a209443a5c3fdce3f6 Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Tue, 8 Apr 2025 23:39:18 -0700 Subject: [PATCH 5/6] Do not warn on redirects from markdown-link-check action --- .github/workflows/markdown-link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index 8d6e430d..12f25670 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -17,4 +17,4 @@ jobs: uses: becheran/mlc@v0.21.0 with: # Ignore external links that result in 403 errors during CI - args: --ignore-links "http*://www.anthropic.com/*,http*://hackerone.com/anthropic-vdp/*" ./ + args: --ignore-links "https://www.anthropic.com/*,https://hackerone.com/anthropic-vdp/*" --do-not-warn-for-redirect-to "https://modelcontextprotocol.io/*,https://github.com/login?*" ./ From 617fc1e951d180ecd6929c08593f11a6a89b6694 Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Tue, 8 Apr 2025 23:41:50 -0700 Subject: [PATCH 6/6] Update comment --- .github/workflows/markdown-link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index 12f25670..3229db07 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -16,5 +16,5 @@ jobs: - name: Markup Link Checker (mlc) uses: becheran/mlc@v0.21.0 with: - # Ignore external links that result in 403 errors during CI + # Ignore external links that result in 403 errors during CI. Do not warn for redirects where we want to keep the vanity URL in the markdown or for GitHub links that redirect to the login. args: --ignore-links "https://www.anthropic.com/*,https://hackerone.com/anthropic-vdp/*" --do-not-warn-for-redirect-to "https://modelcontextprotocol.io/*,https://github.com/login?*" ./