Skip to content

Commit 68649f1

Browse files
committed
Also build+test with Sequoia
Relies on containers/automation_images#411 . Signed-off-by: Miloslav Trmač <[email protected]>
1 parent 2d6ae4e commit 68649f1

File tree

3 files changed

+24
-6
lines changed

3 files changed

+24
-6
lines changed

.cirrus.yml

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,14 @@ env:
2121
SCRIPT_BASE: "./contrib/cirrus"
2222

2323
# Google-cloud VM Images
24-
IMAGE_SUFFIX: "c20250721t181111z-f42f41d13"
24+
# If you are updating IMAGE_SUFFIX: We are currently using rawhide for
25+
# the containers_image_sequoia tests because the rust-podman-sequoia
26+
# package is not available in earlier releases; once we update to a future
27+
# Fedora release (or if the package is backported), switch back from Rawhide
28+
# to the latest Fedora release.
29+
IMAGE_SUFFIX: "c20250812t173301z-f42f41d13"
2530
FEDORA_CACHE_IMAGE_NAME: "fedora-${IMAGE_SUFFIX}"
31+
RAWHIDE_CACHE_IMAGE_NAME: "rawhide-${IMAGE_SUFFIX}"
2632

2733
# Container FQIN's
2834
FEDORA_CONTAINER_FQIN: "quay.io/libpod/fedora_podman:${IMAGE_SUFFIX}"
@@ -190,14 +196,21 @@ test_skopeo_task:
190196
# Required to be 200gig, do not modify - has i/o performance impact
191197
# according to gcloud CLI tool warning messages.
192198
disk: 200
193-
image_name: ${FEDORA_CACHE_IMAGE_NAME}
199+
image_name: ${VM_IMAGE_NAME}
194200
matrix:
195201
- name: "Skopeo Test" # N/B: Name ref. by hack/get_fqin.sh
196202
env:
197203
BUILDTAGS: ''
204+
VM_IMAGE_NAME: ${FEDORA_CACHE_IMAGE_NAME}
198205
- name: "Skopeo Test w/ opengpg"
199206
env:
200207
BUILDTAGS: *withopengpg
208+
VM_IMAGE_NAME: ${FEDORA_CACHE_IMAGE_NAME}
209+
- name: "Skopeo test w/ Sequoia (currently Rawhide)"
210+
env:
211+
BUILDTAGS: 'containers_image_sequoia'
212+
# If you are removing the use of rawhide, also remove the VM_IMAGE_NAME condition from runner.sh .
213+
VM_IMAGE_NAME: ${RAWHIDE_CACHE_IMAGE_NAME}
201214
setup_script: >-
202215
"${GOSRC}/${SCRIPT_BASE}/runner.sh" setup
203216
vendor_script: >-
@@ -226,6 +239,7 @@ meta_task:
226239
# Space-separated list of images used by this repository state
227240
IMGNAMES: |
228241
${FEDORA_CACHE_IMAGE_NAME}
242+
${RAWHIDE_CACHE_IMAGE_NAME}
229243
build-push-${IMAGE_SUFFIX}
230244
BUILDID: "${CIRRUS_BUILD_ID}"
231245
REPOREF: "${CIRRUS_REPO_NAME}"

Makefile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ GOBIN := $(shell $(GO) env GOBIN)
2424
GOOS ?= $(shell go env GOOS)
2525
GOARCH ?= $(shell go env GOARCH)
2626

27+
SEQUOIA_SONAME_DIR =
28+
2729
# N/B: This value is managed by Renovate, manual changes are
2830
# possible, as long as they don't disturb the formatting
2931
# (i.e. DO NOT ADD A 'v' prefix!)
@@ -84,7 +86,7 @@ CONTAINER_RUN ?= $(CONTAINER_CMD) --security-opt label=disable -v $(CURDIR):$(CO
8486
GIT_COMMIT := $(shell GIT_CEILING_DIRECTORIES=$$(cd ..; pwd) git rev-parse HEAD 2> /dev/null || true)
8587

8688
EXTRA_LDFLAGS ?=
87-
SKOPEO_LDFLAGS := -ldflags '-X main.gitCommit=${GIT_COMMIT} $(EXTRA_LDFLAGS)'
89+
SKOPEO_LDFLAGS := -ldflags '-X main.gitCommit=${GIT_COMMIT} -X github.com/containers/image/v5/signature/internal/sequoia.sequoiaLibraryDir=$(SEQUOIA_SONAME_DIR) $(EXTRA_LDFLAGS)'
8890

8991
MANPAGES_MD = $(wildcard docs/*.md)
9092
MANPAGES ?= $(MANPAGES_MD:%.md=%)
@@ -251,7 +253,7 @@ validate-docs: bin/skopeo
251253
hack/xref-helpmsgs-manpages
252254

253255
test-unit-local:
254-
$(GO) test -tags "$(BUILDTAGS)" $$($(GO) list -tags "$(BUILDTAGS)" -e ./... | grep -v '^github\.com/containers/skopeo/\(integration\|vendor/.*\)$$')
256+
$(GO) test $(SKOPEO_LDFLAGS) -tags "$(BUILDTAGS)" $$($(GO) list -tags "$(BUILDTAGS)" -e ./... | grep -v '^github\.com/containers/skopeo/\(integration\|vendor/.*\)$$')
255257

256258
vendor:
257259
$(GO) mod tidy

contrib/cirrus/runner.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,10 @@ _run_setup() {
7171
# automation, but the sources are in different directories. It's
7272
# possible for a mismatch to happen, but should (hopefully) be unlikely.
7373
# Double-check to make sure.
74+
# Temporarily, allow running on Rawhide VMs and consuming older binaries:
75+
# that should be compatible enough. Eventually, we’ll stop using Rawhide again.
7476
if ! grep -Fqx "ID=$OS_RELEASE_ID" $mnt/etc/os-release || \
75-
! grep -Fqx "VERSION_ID=$OS_RELEASE_VER" $mnt/etc/os-release; then
77+
{ ! [[ "$VM_IMAGE_NAME" =~ "rawhide" ]] && ! grep -Fqx "VERSION_ID=$OS_RELEASE_VER" $mnt/etc/os-release; } then
7678
die "Somehow $SKOPEO_CIDEV_CONTAINER_FQIN is not based on $OS_REL_VER."
7779
fi
7880
msg "Copying test binaries from $SKOPEO_CIDEV_CONTAINER_FQIN /usr/local/bin/"
@@ -97,7 +99,7 @@ _run_vendor() {
9799

98100
_run_build() {
99101
make bin/skopeo BUILDTAGS="$BUILDTAGS"
100-
make install PREFIX=/usr/local
102+
make install PREFIX=/usr/local BUILDTAGS="$BUILDTAGS"
101103
}
102104

103105
_run_cross() {

0 commit comments

Comments
 (0)