Skip to content

Commit ca11dd8

Browse files
youkaichaomzusman
authored andcommitted
[ci]try to fix flaky multi-step tests (vllm-project#11894)
Signed-off-by: youkaichao <[email protected]>
1 parent 1b35b9f commit ca11dd8

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

tests/multi_step/test_correctness_async_llm.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
NUM_PROMPTS = [10]
1717

1818
DEFAULT_SERVER_ARGS: List[str] = [
19-
"--disable-log-requests",
2019
"--worker-use-ray",
2120
"--gpu-memory-utilization",
2221
"0.85",
@@ -110,7 +109,7 @@ async def test_multi_step(
110109

111110
# Spin up client/server & issue completion API requests.
112111
# Default `max_wait_seconds` is 240 but was empirically
113-
# was raised 3x to 720 *just for this test* due to
112+
# was raised 5x to 1200 *just for this test* due to
114113
# observed timeouts in GHA CI
115114
ref_completions = await completions_with_server_args(
116115
prompts,

tests/utils.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,13 +157,19 @@ def url_root(self) -> str:
157157
def url_for(self, *parts: str) -> str:
158158
return self.url_root + "/" + "/".join(parts)
159159

160-
def get_client(self):
160+
def get_client(self, **kwargs):
161+
if "timeout" not in kwargs:
162+
kwargs["timeout"] = 600
161163
return openai.OpenAI(
162164
base_url=self.url_for("v1"),
163165
api_key=self.DUMMY_API_KEY,
166+
max_retries=0,
167+
**kwargs,
164168
)
165169

166170
def get_async_client(self, **kwargs):
171+
if "timeout" not in kwargs:
172+
kwargs["timeout"] = 600
167173
return openai.AsyncOpenAI(base_url=self.url_for("v1"),
168174
api_key=self.DUMMY_API_KEY,
169175
max_retries=0,
@@ -780,7 +786,6 @@ async def completions_with_server_args(
780786
assert len(max_tokens) == len(prompts)
781787

782788
outputs = None
783-
max_wait_seconds = 240 * 3 # 240 is default
784789
with RemoteOpenAIServer(model_name,
785790
server_cli_args,
786791
max_wait_seconds=max_wait_seconds) as server:

0 commit comments

Comments
 (0)