fix: Refactor conda--call-json to ignore stderr

Fixes #163. Discards the standard error from the `conda` command,
ensuring that it _should_ be more consistently parseable as JSON.

Author: necaris

conda.el

@@ -170,24 +170,19 @@ See https://github.com/conda/conda/blob/master/CHANGELOG.md#484-2020-08-06."
 (defun conda--call-json (&rest args)
   "Call Conda with ARGS, assuming we return JSON."
   (let* ((conda (conda--get-executable-path))
-         (fmt (format "shell.%s+json"  (if (eq system-type 'windows-nt) "cmd.exe" "posix")))
-         (process-file-args (append (list conda nil t nil) args))
-         (output (with-output-to-string
-                   (with-current-buffer
-                       standard-output
-                     (apply #'process-file process-file-args)))))
+         (output (with-temp-buffer
+                   ;; We set the `destination' to ignore stderr -- this may come
+                   ;; back to bite us if anything important is communicated
+                   ;; there
+                   (apply #'call-process
+                          (append (list conda nil '(t nil) nil) args))
+                   (buffer-string))))
     (condition-case err
-        ;; (if (version< emacs-version "27.1")
-        ;;     (json-read-from-string output)
-        ;;   (json-parse-string output :object-type 'alist :null-object nil))
-        (if (progn
-              (require 'json)
-              (fboundp 'json-parse-string))
-	    (json-parse-string output :object-type 'alist :null-object nil)
+        (if (and (require 'json) (fboundp 'json-parse-string))
+            (json-parse-string output :object-type 'alist :null-object nil)
           (json-read-from-string output))
       (error "Could not parse %s as JSON: %s" output err))))
 
-
 (defvar conda--config nil
   "Cached copy of configuration that Conda sees (including `condarc', etc).
 Set for the lifetime of the process.")