dns: fix parse memory leaky

PR-URL: #58973
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: theanarkh

src/cares_wrap.cc

@@ -1565,6 +1565,8 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,
 
   if (status != ARES_SUCCESS) return Just<int>(status);
 
+  auto cleanup = OnScopeLeave([&]() { ares_free_data(soa_out); });
+
   Local<Object> soa_record = Object::New(env->isolate());
 
   if (soa_record
@@ -1605,8 +1607,6 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,
     return Nothing<int>();
   }
 
-  ares_free_data(soa_out);
-
   wrap->CallOnComplete(soa_record);
   return Just<int>(ARES_SUCCESS);
 }