http: optimize IncomingMessage._dump

Signed-off-by: RafaelGSS <[email protected]>
Co-Authored-By: RafaelGSS <[email protected]>

Author: ronag

doc/api/http.md

@@ -3537,6 +3537,9 @@ Found'`.
 <!-- YAML
 added: v0.1.13
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/59778
+    description: Add fastDump option.
   - version:
     - v20.1.0
     - v18.17.0
@@ -3632,6 +3635,11 @@ changes:
   * `rejectNonStandardBodyWrites` {boolean} If set to `true`, an error is thrown
     when writing to an HTTP response which does not have a body.
     **Default:** `false`.
+  * `fastDump` {boolean} If set to `true`, request body for `HEAD` and `GET`
+    requests will be immediatly dumped and the `end` and `close` events for
+    `IncomingMessage` will be emitted before the server emits `'request'`. This
+    enables some optimizations that would otherwise not be possible.
+    **Default:** `false`.
 
 * `requestListener` {Function}
 

lib/_http_server.js

@@ -106,6 +106,8 @@ const onResponseFinishChannel = dc.channel('http.server.response.finish');
 const kServerResponse = Symbol('ServerResponse');
 const kServerResponseStatistics = Symbol('ServerResponseStatistics');
 
+const kfastDump = Symbol('FastDumpOption');
+
 const {
   hasObserver,
   startPerf,
@@ -452,6 +454,11 @@ function storeHTTPOptions(options) {
     validateInteger(maxHeaderSize, 'maxHeaderSize', 0);
   this.maxHeaderSize = maxHeaderSize;
 
+  const fastDump = options.fastDump;
+  if (fastDump !== undefined)
+    validateBoolean(fastDump, 'options.fastDump');
+  this[kfastDump] = fastDump || false;
+
   const insecureHTTPParser = options.insecureHTTPParser;
   if (insecureHTTPParser !== undefined)
     validateBoolean(insecureHTTPParser, 'options.insecureHTTPParser');
@@ -1102,6 +1109,23 @@ function parserOnIncoming(server, socket, state, req, keepAlive) {
     });
   }
 
+  if (req[kfastDump] === true && (req.method === 'HEAD' || req.method === 'GET')) {
+    // Fast dump where request "has" already emitted all lifecycle events.
+    // This avoid a lot of unnecessary overhead otherwise introduced by
+    // stream.Readable life cycle rules. The downside is that this will
+    // break some servers that read GET bodies.
+
+    req._dumped = true;
+    // TODO: move that to lazy_transform.js
+    req._readableState.ended = true;
+    req._readableState.endEmitted = true;
+    req._readableState.destroyed = true;
+    req._readableState.closed = true;
+    req._readableState.closeEmitted = true;
+
+    req._read();
+  }
+
   if (socket._httpMessage) {
     // There are already pending outgoing res, append.
     state.outgoing.push(res);

test/parallel/test-http-chunk-extensions-limit.js

@@ -124,7 +124,7 @@ const assert = require('assert');
     }));
 
     sock.end('' +
-      'GET / HTTP/1.1\r\n' +
+      'PUT / HTTP/1.1\r\n' +
       `Host: localhost:${port}\r\n` +
       'Transfer-Encoding: chunked\r\n\r\n' +
       '2;' + 'A'.repeat(10000) + '=bar\r\nAA\r\n' +

test/parallel/test-http.js

@@ -52,12 +52,18 @@ const server = http.Server(common.mustCall((req, res) => {
   if (expectedRequests.length === 0)
     server.close();
 
-  req.on('end', () => {
+  if (req.readableEnded) {
     res.writeHead(200, { 'Content-Type': 'text/plain' });
     res.write(`The path was ${url.parse(req.url).pathname}`);
     res.end();
-  });
-  req.resume();
+  } else {
+    req.on('end', () => {
+      res.writeHead(200, { 'Content-Type': 'text/plain' });
+      res.write(`The path was ${url.parse(req.url).pathname}`);
+      res.end();
+    });
+    req.resume();
+  }
 }, 3));
 server.listen(0);