Skip to content

Commit b797e51

Browse files
theanarkhmarco-ippolito
authored andcommitted
dns: fix parse memory leaky
PR-URL: #58973 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent bf93f46 commit b797e51

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/cares_wrap.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1319,6 +1319,8 @@ int SoaTraits::Parse(
13191319
if (status != ARES_SUCCESS)
13201320
return status;
13211321

1322+
auto cleanup = OnScopeLeave([&]() { ares_free_data(soa_out); });
1323+
13221324
Local<Object> soa_record = Object::New(env->isolate());
13231325

13241326
soa_record->Set(env->context(),
@@ -1345,8 +1347,6 @@ int SoaTraits::Parse(
13451347
Integer::NewFromUnsigned(
13461348
env->isolate(), soa_out->minttl)).Check();
13471349

1348-
ares_free_data(soa_out);
1349-
13501350
wrap->CallOnComplete(soa_record);
13511351
return ARES_SUCCESS;
13521352
}

0 commit comments

Comments
 (0)