Skip to content

Conversation

adjabaev
Copy link
Contributor

@adjabaev adjabaev commented May 31, 2025

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added Luxembourgish (lb) locale support for Nuxt UI.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@adjabaev adjabaev requested a review from benjamincanac as a code owner May 31, 2025 02:59
Copy link

pkg-pr-new bot commented May 31, 2025

npm i https://pkg.pr.new/@nuxt/ui@4264

commit: 901961b

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is correct? I couldn't find any lb language code: http://www.lingoes.net/en/translator/langcode.htm

It seems there's only fr-LU and de-LU πŸ€”

@adjabaev
Copy link
Contributor Author

adjabaev commented Jun 1, 2025

Are you sure this is correct? I couldn't find any lb language code: http://www.lingoes.net/en/translator/langcode.htm

It seems there's only fr-LU and de-LU πŸ€”

Yes I am! There are three official languages in Luxembourg

ex:
https://learn.microsoft.com/lb-lu/

https://simplelocalize.io/data/locale-code/lb-LU/

@benjamincanac
Copy link
Member

Then I think you're missing a lb: 'lu' mapping in SupportedLanguages.vue to display the correct flag: https://github.com/nuxt/ui/blob/v3/docs/app/components/content/SupportedLanguages.vue#L29

@adjabaev
Copy link
Contributor Author

adjabaev commented Jun 3, 2025

Then I think you're missing a lb: 'lu' mapping in SupportedLanguages.vue to display the correct flag: https://github.com/nuxt/ui/blob/v3/docs/app/components/content/SupportedLanguages.vue#L29

Fixed :)

@benjamincanac
Copy link
Member

Thanks! 😊

@benjamincanac benjamincanac merged commit 43cbb94 into nuxt:v3 Jun 5, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants