Skip to content

Conversation

genu
Copy link
Member

@genu genu commented Jun 6, 2025

πŸ”— Linked issue

This is an extension of the this PR: #4269. Specifically this comment

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Ensures that when defaultOpen is true, we are properly setting the props to the originalProps that are passed it.

This PR also includes a different strategy for patch. We now spread props instead of updating each one individually. There shouldn't be any impact in this particular change, but its necessary to allow clearing props.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@genu genu requested a review from benjamincanac as a code owner June 6, 2025 21:43
@genu genu changed the title fix: fix/issue with original props not set when defaultOpen is set fix: set props to original props when defaultOpen is set Jun 6, 2025
Copy link

pkg-pr-new bot commented Jun 6, 2025

npm i https://pkg.pr.new/@nuxt/ui@4308

commit: 1c7e7d0

@genu genu changed the title fix: set props to original props when defaultOpen is set fix(useOverlay): set props to original props when defaultOpen is set Jun 7, 2025
@benjamincanac benjamincanac merged commit 66355ba into nuxt:v3 Jun 11, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants