Skip to content

Conversation

genu
Copy link
Member

@genu genu commented Jul 10, 2025

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a fix to the comment left on the PR here: #4478 (comment)

Note: This case is also covered in the tests in #4482

It makes sense that .open shouldn't ever be patching props. open should always be either using the original props (defined in the create), or merge the original props with any new props.

Doing a patch was incorrect.

πŸ“ Checklist

  • [] I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@genu genu requested a review from benjamincanac as a code owner July 10, 2025 04:05
@genu genu mentioned this pull request Jul 10, 2025
8 tasks
Copy link

pkg-pr-new bot commented Jul 10, 2025

npm i https://pkg.pr.new/@nuxt/ui@4497

commit: df5e97c

@TPORL
Copy link

TPORL commented Jul 10, 2025

it work! thx...

@benjamincanac benjamincanac merged commit 5ad7dab into nuxt:v3 Jul 10, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants