fix(useOverlay): don't use patch
when passing props to open
#4497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
π Description
This is a fix to the comment left on the PR here: #4478 (comment)
Note: This case is also covered in the tests in #4482
It makes sense that
.open
shouldn't ever be patching props.open
should always be either using the original props (defined in thecreate
), or merge the original props with any new props.Doing a patch was incorrect.
π Checklist