Skip to content

fix(RadioGroup): improve type safety for normalizeItem function #4535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2025
Merged

fix(RadioGroup): improve type safety for normalizeItem function #4535

merged 4 commits into from
Jul 16, 2025

Conversation

rdjanuar
Copy link
Contributor

@rdjanuar rdjanuar commented Jul 16, 2025 •
edited
Loading

🔗 Linked issue

Resolves #4533

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar requested a review from benjamincanac as a code owner July 16, 2025 05:08
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 16, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4535

commit: d0bb83f

@rdjanuar rdjanuar changed the title refactor(radiogroup): improve type safety for normalizeItem function refactor(RadioGroup): improve type safety for normalizeItem function Jul 16, 2025
@benjamincanac benjamincanac changed the title refactor(RadioGroup): improve type safety for normalizeItem function fix(RadioGroup): improve type safety for normalizeItem function Jul 16, 2025
@benjamincanac benjamincanac requested a review from sandros94 July 16, 2025 09:57
sandros94
sandros94 approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@sandros94 sandros94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice approach

@benjamincanac benjamincanac merged commit bb99345 into nuxt:v3 Jul 16, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandros94 sandros94 sandros94 approved these changes

@benjamincanac benjamincanac Awaiting requested review from benjamincanac benjamincanac is a code owner

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[URadioGroup] Typing Issue on Label Slots
3 participants
@rdjanuar @sandros94 @benjamincanac