-
Notifications
You must be signed in to change notification settings - Fork 854
fix(InputMenu/Select/SelectMenu): add display value fallback when no items found #4689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
Would you mind doing the same for InputMenu, I'm pretty sure this would solve #4635! |
done @benjamincanac, i already check yes it solve the issue |
Maybe this needs to be done in the Select component as well π€ Maybe we could create an utility to unify this. |
do you have suggestion for naming utils file @benjamincanac ? |
Maybe |
I'm finished move the function, but there's an issue with type. can you help me to fix it @benjamincanac ? |
@rdjanuar I've updated the PR, not really sure why the snapshots of the InputMenu have changed though π€ |
π Linked issue
Resolves #4582, resolves #4635
β Type of change
π Description
π Checklist