Skip to content

Conversation

rdjanuar
Copy link
Contributor

@rdjanuar rdjanuar commented Aug 9, 2025

πŸ”— Linked issue

Resolves #4582, resolves #4635

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar requested a review from benjamincanac as a code owner August 9, 2025 18:44
Copy link

pkg-pr-new bot commented Aug 9, 2025

npm i https://pkg.pr.new/@nuxt/ui@4689

commit: 427ed00

@rdjanuar rdjanuar requested a review from J-Michalek August 11, 2025 06:59
@benjamincanac
Copy link
Member

Would you mind doing the same for InputMenu, I'm pretty sure this would solve #4635!

@rdjanuar
Copy link
Contributor Author

done @benjamincanac, i already check yes it solve the issue

@benjamincanac benjamincanac changed the title fix(SelectMenu): add fallback for displayed value while no items found fix(InputMenu/SelectMenu): add display value fallbaack when no items found Aug 12, 2025
@benjamincanac benjamincanac changed the title fix(InputMenu/SelectMenu): add display value fallbaack when no items found fix(InputMenu/SelectMenu): add display value fallback when no items found Aug 12, 2025
@benjamincanac
Copy link
Member

Maybe this needs to be done in the Select component as well πŸ€” Maybe we could create an utility to unify this.

@rdjanuar
Copy link
Contributor Author

do you have suggestion for naming utils file @benjamincanac ?

@benjamincanac
Copy link
Member

benjamincanac commented Aug 12, 2025

Maybe getDisplayValue inside src/runtime/utils/index.ts next to compare?

@rdjanuar
Copy link
Contributor Author

rdjanuar commented Aug 12, 2025

I'm finished move the function, but there's an issue with type. can you help me to fix it @benjamincanac ?

@benjamincanac benjamincanac changed the title fix(InputMenu/SelectMenu): add display value fallback when no items found fix(InputMenu/Select/SelectMenu): add display value fallback when no items found Aug 13, 2025
@benjamincanac
Copy link
Member

@rdjanuar I've updated the PR, not really sure why the snapshots of the InputMenu have changed though πŸ€”

@benjamincanac benjamincanac merged commit 34ca811 into nuxt:v3 Aug 14, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
3 participants