Skip to content

fix(Input): incorrect rendering of type date / time on iOS #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2025
Merged

fix(Input): incorrect rendering of type date / time on iOS #4715

merged 5 commits into from
Aug 14, 2025

Conversation

yeonjulee1005
Copy link
Contributor

@yeonjulee1005 yeonjulee1005 commented Aug 12, 2025 •
edited by benjamincanac
Loading

🔗 Linked issue

Resolves #4712

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@yeonjulee1005 yeonjulee1005 changed the title fix input style in IOS fix(input): fix incorrect rendering of UInput with type date or time on iOS Aug 12, 2025
@yeonjulee1005 yeonjulee1005 changed the title fix(input): fix incorrect rendering of UInput with type date or time on iOS fix(UInput): fix incorrect rendering of UInput with type date or time on iOS Aug 12, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 12, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4715

commit: fe9b26a

benjamincanac
benjamincanac requested changes Aug 13, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the appearance-none class on the base slot inside src/theme/input.ts instead of define a dynamic style here.

@yeonjulee1005
- Move appearance-none input style to the base slot
cb98f2f 
- Update snapshot files that include the `input` tag
@yeonjulee1005
Copy link
Contributor Author

@benjamincanac
Thanks for telling me!

I've updated it as you suggested!

  • Move appearance-none input style to the base slot
  • Update snapshot files that include the input tag

@benjamincanac benjamincanac changed the title fix(UInput): fix incorrect rendering of UInput with type date or time on iOS fix(Input): incorrect rendering of type date / time on iOS Aug 14, 2025
@benjamincanac
Copy link
Member

Thanks @yeonjulee1005! 😊

@benjamincanac benjamincanac merged commit 93cc83c into nuxt:v3 Aug 14, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS Safari: Input with type 'date' or 'time' renders incorrectly
2 participants
@yeonjulee1005 @benjamincanac