-
Notifications
You must be signed in to change notification settings - Fork 854
fix(components): broken types for update:model-value
event
#4853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The accept prop did not work with image/* etc.
This reverts commit 5b75835.
The accept prop did not work with image/* etc.
Seems like the defineModel and the FileUploadEmits interface had some kind of a conflict when resolving.
commit: |
β¦ fix/file-upload-emits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it would be easier to just remove it from the FileUploadEmits
interface, what do you think?
Also, I noticed we have the same error in the Slider component and maybe others π€
@benjamincanac Yeah I also saw it in more components, but I did not try if it works there... I also saw it used together with |
I would only remove it when used with |
Sure, I will take care of it. |
update:model-value
event
@J-Michalek I took the liberty to push to your PR and rename at the same time some events for consistency, let me know what you think! |
LGTM! |
π Linked issue
Resolves: #4852
β Type of change
π Description
I've omitted the
update:modelValue
event from theFileUploadEmits
interface used indefineEmits
as the type seems to break when used in bothdefineModel
anddefineEmits
at the same time.π Checklist