[osh] Disable partially broken check for parsing options in functions

- For ble.sh compatibility with shopt -u expand_aliases - #1069
- the check worked in shell functions, but was broken in proc/func

Author: Andy C

core/state.py

@@ -466,10 +466,18 @@ def set_emacs(self):
 
     def _SetArrayByNum(self, opt_num, b):
         # type: (int, bool) -> None
+        """
+        Disabled check: ParsingChangesAllowed() worked for shell functions, but
+        was broken for proc and func.  Because they don't use the argv stack.
+
+        It also doesn't work for 'eval' and 'source', as shown by ble.sh.
+        (Although source inside a function is an odd usage.)
+
         if (opt_num in consts.PARSE_OPTION_NUMS and
                 not self.mem.ParsingChangesAllowed()):
             e_die('Syntax options must be set at the top level '
                   '(outside any function)')
+        """
 
         self._Set(opt_num, b)
 
@@ -1335,15 +1343,6 @@ def SetPwd(self, pwd):
         """Used by builtins."""
         self.pwd = pwd
 
-    def ParsingChangesAllowed(self):
-        # type: () -> bool
-        """For checking that syntax options are only used at the top level."""
-
-        # DISALLOW proc calls     : they push argv_stack, var_stack, debug_stack
-        # ALLOW source foo.sh arg1: pushes argv_stack, debug_stack
-        # ALLOW FOO=bar           : pushes var_stack
-        return len(self.var_stack) == 1 or len(self.argv_stack) == 1
-
     def Dump(self):
         # type: () -> Tuple[List[value_t], List[value_t], List[value_t]]
         """Copy state before unwinding the stack."""

soil/worker.sh

@@ -368,13 +368,15 @@ dump-env          soil/diagnose.sh dump-env            -
 py-all            build/py.sh all                      -
 ble-clone         test/ble.sh clone                    -
 ble-build         test/ble.sh build                    -
-ble-bash-suite    test/ble.sh bash-suite               -
 ble-test-osh-py   test/ble.sh run-tests-osh-py         -
 wait-for-tarball  soil/wait.sh for-cpp-tarball         -
 test-tar          devtools/release-native.sh test-tar  -
 ble-test-osh-cpp  test/ble.sh run-tests-osh-cpp        -
 EOF
 
+# 2025-02 - times out after 15 minutes?  This is just bash, not OSH?
+# ble-bash-suite    test/ble.sh bash-suite               -
+
 # This doesn't work
 # ble-test-osh-bash test/ble.sh run-tests-osh-bash       -
 }

spec/ble-idioms.test.sh

@@ -269,3 +269,23 @@ echo "${a[@]}"
 
 ## N-I mksh/ash STDOUT:
 ## END
+
+#### shopt -u expand_aliases and eval
+case $SH in zsh|mksh|ash) exit ;; esac
+
+alias echo=false
+
+function f {
+  shopt -u expand_aliases
+  eval -- "$1"
+  shopt -s expand_aliases
+}
+
+f 'echo hello'
+
+## STDOUT:
+hello
+## END
+## N-I zsh/mksh/ash STDOUT:
+## END
+

spec/ysh-options.test.sh

@@ -1,3 +1,5 @@
+## oils_failures_allowed: 1
+
 # Test shell execution options.
 
 #### simple_word_eval doesn't split, glob, or elide empty
@@ -75,7 +77,11 @@ argv.py @words
 ['a', 'b c']
 ## END
 
-#### parse_at can't be used outside top level
+#### DISABLED: parse_at can't be used outside top level
+
+# shopt -u expand_aliases conflicted with ble.sh, and it was also broken for
+# proc/func
+
 f() {
   shopt -s parse_at
   echo status=$?