diff --git a/Acceptance-Tests.md b/Acceptance-Tests.md index 2302a24b..79274579 100644 --- a/Acceptance-Tests.md +++ b/Acceptance-Tests.md @@ -247,6 +247,67 @@ On CI, we run all the acceptance tests in production mode, so the screenshots in On the other hand, if the screenshot fails locally (in desktop environment), the screenshot `teachPage-diff.png` will be generated and stored inside a new folder `diff-snapshots` under `logged-out-user/dev-desktop-screenshots`. +### Adding Prod screenshots for Acceptance Tests +On making changes that affect a user journey tested through the acceptance tests or introduce a new feature, a contributor needs to update/add screenshots supporting their changes. +It has been noted that screenshots obtained by running the Acceptance tests locally using the prod flag do not match those captured by the CI. To overcome this, you can commit any image in the prod screenshot folder and follow these steps: +1. Go to the failing run and click on the 'uploading diff screenshots as an artifact' section: + image + +2. Then download the artifact from the artifact download url: + image + +3. Extract the contents of the artifact. There will be a folder with an image. The image will be like this: + skillWithWorkedExamplePreview-diff + + The left side is the current reference image on the repo. The right side is the screenshot that was taken while running the test on the CI with your changes. The middle is the difference between the two. + + We want to update the current reference as it is incorrect. Generally we do not want to do this as we expect the reference screenshots to be correct. Only do this after asking a maintainer. + +4. Go to https://splitter.imageonline.co/ + +5. Upload the diff image from the artifact you extracted: +image + +6. Choose Split into pieces: +image + +7. Set rows as 3 and columns as 1: +image + +8. Click on split image + +9. You will get 3 split images: +image + +10. Right click on the rightmost one and use 'Save Image as...'. Choose any random name. + +11. Navigate to where you have saved the Oppia repo on your local machine. + +12. Go to oppia/core/tests/puppeteer-acceptance-tests/specs + +13. The spec will be mentioned in the artifact folder you downloaded: + +Screenshot from 2025-08-20 16-37-52 + +(Its curriculum-admin in this case) + +14. Navigate to the spec + +15. Check if the failure was for desktop or mobile based on the screenshot or the subfolder in the artifact: +image + +16. Go to the prod-desktop-screenshots/prod-mobile-screenshots folder depending on your failure + +17. Paste the image we split. + +18. Check the name of the image from the artifact. It will be {screenshot_name}-diff.png + +19. Delete the screenshot with {screenshot_name}-snap.png from the folder you are currently in. + +20. Rename the pasted image to {screenshot_name}-snap.png + +21. Check that the correct image got replaced, commit and push your changes! + ## Acceptance Tests for Mobile Similar to desktop, we also have acceptance tests for mobile to ensure responsiveness and uninterrupted user journeys on small screen devices. While the tests themselves remain largely the same for both desktop and mobile, there are some differences. For instance, large full menus on desktop may be converted to dropdowns, hamburger menus, or other shortcuts on mobile, requiring additional actions to complete the tests.