Skip to content

Commit 6427542

Browse files
committed
Default the PathConverter (and descendants) to be non part isolating
This is likely to be the expected for anything that is or extends the PathConverter and by adding it explicitly I hope it will cause less confusion, as seen in a recent issue 2783. Note the PathConverter was already non part isolating due to the BaseConverter check.
1 parent 4820d8c commit 6427542

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

CHANGES.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Unreleased
1212
- Add the ``"werkzeug.profiler"`` item to the WSGI ``environ`` dictionary
1313
passed to `ProfilerMiddleware`'s `filename_format` function. It contains
1414
the ``elapsed`` and ``time`` values for the profiled request. :issue:`2775`
15+
- Explicitly marked the PathConverter as non path isolating. :pr:`2784`
1516

1617

1718
Version 2.3.8

src/werkzeug/routing/converters.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ class PathConverter(BaseConverter):
119119
:param map: the :class:`Map`.
120120
"""
121121

122+
part_isolating = False
122123
regex = "[^/].*?"
123124
weight = 200
124125

0 commit comments

Comments
 (0)