Skip to content

Commit 9de3349

Browse files
authored
Bugfixes to card, river and image components (#971)
1 parent c2d5b34 commit 9de3349

File tree

38 files changed

+40
-9
lines changed

38 files changed

+40
-9
lines changed

.changeset/early-kangaroos-lick.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react-brand': patch
3+
---
4+
5+
Fixed border radius inconsistency in the `River` component where `picture` elements were only showing rounded corners at the top but not the bottom.

.changeset/silver-pants-matter.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react-brand': patch
3+
---
4+
5+
`River` headings and body text now have a maximum width of `400px` on default 50:50 layouts.

.changeset/tame-pants-cheer.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react-brand': patch
3+
---
4+
5+
Fixed border radius inconsistency in the `Card` component where `picture` elements were only showing rounded corners at the top but not the bottom.

packages/react/src/Card/Card.features.stories.tsx

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -228,13 +228,22 @@ export const IconAndLabel: StoryFn<typeof Card> = () => {
228228

229229
export const Image: StoryFn<typeof Card> = () => {
230230
return (
231-
<Card href="https://github.com">
232-
<Card.Image src={placeholderImage} alt="placeholder, blank area with an gray background color" />
233-
<Card.Heading>Code search & code view</Card.Heading>
234-
<Card.Description>
235-
Enables you to rapidly search, navigate, and understand code, right from GitHub.com.
236-
</Card.Description>
237-
</Card>
231+
<Stack direction="horizontal">
232+
<Card href="https://github.com">
233+
<Card.Image src={placeholderImage} alt="placeholder, blank area with an gray background color" />
234+
<Card.Heading>Code search & code view</Card.Heading>
235+
<Card.Description>
236+
Enables you to rapidly search, navigate, and understand code, right from GitHub.com.
237+
</Card.Description>
238+
</Card>
239+
<Card href="https://github.com">
240+
<Card.Image as="picture" src={placeholderImage} alt="placeholder, blank area with an gray background color" />
241+
<Card.Heading>Code search & code view</Card.Heading>
242+
<Card.Description>
243+
Enables you to rapidly search, navigate, and understand code, right from GitHub.com.
244+
</Card.Description>
245+
</Card>
246+
</Stack>
238247
)
239248
}
240249

packages/react/src/Card/Card.module.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
}
134134

135135
.Card__image img,
136+
.Card__image picture,
136137
.Card__image span {
137138
display: block;
138139
}
635 Bytes
Loading
Loading
Loading
Loading
Loading

0 commit comments

Comments
 (0)