Skip to content

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Apr 5, 2022

Summary

  • Adds Doctocat with a Homepage, Getting Started and Hero placeholder content
  • Appends built Storybook to /storybook path
  • Removed background color from Hero component
  • Updated README.md

Reviewer notes

Screenshots

Screenshot 2022-04-06 at 10 53 39

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022

🦋 Changeset detected

Latest commit: 111de4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react-brand Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rezrah rezrah temporarily deployed to github-pages April 5, 2022 11:54 Inactive
@rezrah rezrah temporarily deployed to github-pages April 5, 2022 13:27 Inactive
@rezrah rezrah temporarily deployed to github-pages April 5, 2022 13:44 Inactive
@rezrah rezrah temporarily deployed to github-pages April 5, 2022 13:56 Inactive
@rezrah rezrah marked this pull request as ready for review April 5, 2022 14:10
@rezrah rezrah temporarily deployed to github-pages April 5, 2022 14:16 Inactive
@rezrah rezrah requested a review from colebemis April 5, 2022 14:22
@rezrah rezrah temporarily deployed to github-pages April 5, 2022 14:24 Inactive
@rezrah rezrah temporarily deployed to github-pages April 6, 2022 10:43 Inactive
@rezrah rezrah temporarily deployed to github-pages April 6, 2022 11:18 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just left some minor comments—nothing blocking.

I have no idea why check_for_changesets is failing 🤔

title: Hero
status: Experimental
source: https://github.com/primer/react-brand/tree/main/src/Hero/Hero.tsx
description: Use the Hero component to render a full-width banner on a webpage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a storybook link here too:

Suggested change
description: Use the Hero component to render a full-width banner on a webpage
description: Use the Hero component to render a full-width banner on a webpage
storybook: #

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to fix this one in a separate PR

@rezrah rezrah temporarily deployed to github-pages April 7, 2022 12:26 Inactive
@rezrah rezrah merged commit ab06cce into main Apr 7, 2022
@rezrah rezrah deleted the rezrah/set-up-docs branch April 7, 2022 12:32
@primer-css primer-css mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants