Skip to content

Commit 991839c

Browse files
mperrottisiddharthkpkhiga8broccolinisoup
authored
Un-revert "Add loading prop for Button and IconButton (#3582)" (#4485)
* Revert "Revert "Add `loading` prop for `Button` and `IconButton` (#3582)" (#4…" This reverts commit c01901f. * only overrides btn label when loading * update tooltip tests to accomodate loading message aria-describedby * import missing modules in IconButton stories * makes aria-labelledby prop remain set when when button is in a loading state * Update packages/react/src/Button/Button.examples.stories.tsx Co-authored-by: Kate Higa <[email protected]> * Update packages/react/src/Button/Button.examples.stories.tsx Co-authored-by: Kate Higa <[email protected]> * updates textinput snapshots * addresses remaining PR feedback * appeases the linter, updates snaps * leaves loading prop undefined so we do not always render the wrapper * test(vrt): update snapshots * trying again without changing colors on faux-disabled buttons * replaces Status with AriaStatus * replaces one more Status with AriaStatus * rms added aria-disabled styles * test(vrt): update snapshots * Update icon button tests to make it work with the loading state * add story with leading visual and count * misc bugfixes: - ensures counter stays rendered even when no children are passed - preserves space between elements that are children of span[data-component=text] - adds story and VRT for buttons with a trailing action but no leading/trailing visuals * test(vrt): update snapshots --------- Co-authored-by: Siddharth Kshetrapal <[email protected]> Co-authored-by: Kate Higa <[email protected]> Co-authored-by: mperrotti <[email protected]> Co-authored-by: Armagan Ersoz <[email protected]>
1 parent 8574027 commit 991839c

File tree

91 files changed

+1063
-304
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

91 files changed

+1063
-304
lines changed

.changeset/lazy-jobs-pump.md

Lines changed: 5 additions & 0 deletions
-150 Bytes
-61 Bytes
-631 Bytes

0 commit comments

Comments
 (0)