Skip to content

Commit e34e4b2

Browse files
PageHeader: Address dom order issues (screen reader experience feedback from sign-off) (#4358)
* Update layout styles so that all interactive elements come after the title * Add PageHeder.Breadcrumbs sub component * remove shapshot check on jest * test(vrt): update snapshots * test(vrt): update snapshots * make the interactive element in the heading check a warning not error * add pageheader story for screen reader tes * add links * add onclick events to the buttons * add a placeholder for file content example * test(vrt): update snapshots * elements losing context when viewport is narrrow - keep the same text for buttons in all viewports * fix linting * test(vrt): update snapshots * hide the overflow menu in narrow since we show it on the context area * accomodate different format sx prop for font size * when no fontsize is specified css var returns as an empty string so need ternary instead of Nullish coalescing * temporary fix on navlist --------- Co-authored-by: broccolinisoup <[email protected]>
1 parent b1fef5c commit e34e4b2

File tree

73 files changed

+813
-481
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+813
-481
lines changed

.changeset/clever-schools-shave.md

Lines changed: 7 additions & 0 deletions
6.25 KB
6.34 KB
6.23 KB
6.25 KB
6.25 KB
6.31 KB
6.16 KB
6.31 KB
6.31 KB

0 commit comments

Comments
 (0)