Skip to content

Commit 6cd666a

Browse files
authored
Merge pull request #3588 from processing/feat/privatesketch
Feat/privatesketch
2 parents 76d3e27 + c3e160e commit 6cd666a

File tree

4 files changed

+10
-18
lines changed

4 files changed

+10
-18
lines changed

client/modules/IDE/components/Header/MobileNav.jsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,6 @@ const MobileNav = () => {
249249
const userIsOwner = user?.username === project.owner?.username;
250250
const Logo = AsteriskIcon;
251251

252-
const showPrivacyToggle =
253-
project?.owner && title === project.name && userIsOwner;
254252
const showOwner = project?.owner && title === project.name && !userIsOwner;
255253

256254
const toggleVisibility = (e) => {
@@ -274,17 +272,6 @@ const MobileNav = () => {
274272
</LogoContainer>
275273
<Title>
276274
<h1>{title === project?.name ? <ProjectName /> : title}</h1>
277-
{showPrivacyToggle && (
278-
<main className="toolbar__makeprivate">
279-
<p>Private</p>
280-
<input
281-
className="toolbar__togglevisibility"
282-
type="checkbox"
283-
onChange={toggleVisibility}
284-
defaultChecked={project.visibility === 'Private'}
285-
/>
286-
</main>
287-
)}
288275
{showOwner && <h5>by {project?.owner?.username}</h5>}
289276
</Title>
290277

client/modules/IDE/components/Header/Toolbar.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ const Toolbar = (props) => {
122122
</div>
123123
)}
124124

125-
{/* ✅ Still show owner if not you */}
126125
{project?.owner && !userIsOwner && (
127126
<p className="toolbar__project-owner">
128127
{t('Toolbar.By')}{' '}

client/modules/IDE/components/SketchListRowBase.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ const SketchListRowBase = ({
125125
<th scope="row">{name}</th>
126126
<td>{formatDateCell(sketch.createdAt, mobile)}</td>
127127
<td>{formatDateCell(sketch.updatedAt, mobile)}</td>
128-
<td hidden={!userIsOwner}>
128+
<td hidden={!userIsOwner || mobile}>
129129
<VisibilityDropdown
130130
sketch={sketch}
131131
onVisibilityChange={handleVisibilityChange}

client/styles/components/_visibility-dropdown.scss

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545

4646
@include themify() {
4747
border-bottom: 1px solid getThemifyVariable("modal-border-color");
48-
background-color: white;
48+
background-color: getThemifyVariable("modal-background-color");
4949
}
5050

5151
&:last-child {
@@ -54,14 +54,20 @@
5454

5555
&:hover {
5656
@include themify() {
57-
background-color: getThemifyVariable("table-row-stripe-color") !important;
57+
background-color: getThemifyVariable("file-selected-color") !important;
5858
}
5959
}
6060

6161
&.selected {
6262
@include themify() {
63-
background-color: getThemifyVariable("search-background-color");
63+
background-color: getThemifyVariable("table-row-stripe-color");
6464
}
65+
66+
// &:hover {
67+
// @include themify() {
68+
// background-color: getThemifyVariable("table-row-stripe-color") !important;
69+
// }
70+
// }
6571
}
6672
}
6773

0 commit comments

Comments
 (0)