Skip to content

Commit 78b45ea

Browse files
committed
Fixed Snap Store upload & macOS Binary signing
[skip ci]
1 parent 1622bc7 commit 78b45ea

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

.github/workflows/release-gradle.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ jobs:
149149
ORG_GRADLE_PROJECT_compose.desktop.mac.notarization.appleID: ${{ secrets.PROCESSING_APPLE_ID }}
150150
ORG_GRADLE_PROJECT_compose.desktop.mac.notarization.password: ${{ secrets.PROCESSING_APP_PASSWORD }}
151151
ORG_GRADLE_PROJECT_compose.desktop.mac.notarization.teamID: ${{ secrets.PROCESSING_TEAM_ID }}
152-
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.PROCESSING_SNAPCRAFT_TOKEN }}
153152
ORG_GRADLE_PROJECT_snapname: ${{ vars.SNAP_NAME }}
154153

155154
- name: Upload portables to release
@@ -165,3 +164,9 @@ jobs:
165164
repo_token: ${{ secrets.GITHUB_TOKEN }}
166165
asset_name: processing-${{ needs.version.outputs.version }}-${{ matrix.os_prefix }}-${{ matrix.arch }}.${{ matrix.extension }}
167166
file: app/build/compose/binaries/main/${{ matrix.binary }}.${{ matrix.extension }}
167+
168+
- name: Upload snap to Snap Store
169+
if: runner.os == 'Linux'
170+
run: snapcraft upload app/build/compose/binaries/main/${{ matrix.binary }}.${{ matrix.extension }}
171+
env:
172+
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.PROCESSING_SNAPCRAFT_TOKEN }}

app/build.gradle.kts

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -232,16 +232,6 @@ tasks.register<Exec>("packageSnap"){
232232
workingDir = distributable.destinationDir.dir("../").get().asFile
233233
commandLine("snapcraft")
234234
}
235-
tasks.register<Exec>("uploadSnap"){
236-
onlyIf { org.gradle.internal.os.OperatingSystem.current().isLinux }
237-
dependsOn("packageSnap")
238-
group = "compose desktop"
239-
240-
val distributable = tasks.named<AbstractJPackageTask>("createDistributable").get()
241-
workingDir = distributable.destinationDir.dir("../").get().asFile
242-
243-
commandLine("snapcraft upload ${snapname}_${version}_${snaparch}.snap")
244-
}
245235
tasks.register<Zip>("zipDistributable"){
246236
dependsOn("createDistributable")
247237
group = "compose desktop"
@@ -275,7 +265,7 @@ afterEvaluate{
275265
){
276266
dependsOn("notarizeDmg")
277267
}
278-
dependsOn("packageSnap", "uploadSnap")
268+
dependsOn("packageSnap")
279269
}
280270
}
281271

@@ -395,7 +385,7 @@ tasks.register<Copy>("renameWindres") {
395385
duplicatesStrategy = DuplicatesStrategy.INCLUDE
396386
into(dir)
397387
}
398-
tasks.register<Exec>("signResources"){
388+
tasks.register("signResources"){
399389
onlyIf { org.gradle.internal.os.OperatingSystem.current().isMacOsX }
400390
group = "compose desktop"
401391
dependsOn("prepareAppResources")
@@ -427,8 +417,23 @@ tasks.register<Exec>("signResources"){
427417
}
428418
jars.add(tempDir)
429419
}
420+
fileTree(resourcesPath){
421+
include("**/bin/**")
422+
include("**/*.jnilib")
423+
include("**/*.dylib")
424+
include("**/*aarch64*")
425+
include("**/*x86_64*")
426+
exclude("jdk-*/**")
427+
exclude("*.jar")
428+
exclude("*.so")
429+
exclude("*.dll")
430+
}.forEach{ file ->
431+
println("signign $file")
432+
exec {
433+
commandLine("codesign", "--timestamp", "--force", "--deep", "--sign", "Developer ID Application", file)
434+
}
435+
}
430436
}
431-
commandLine("codesign","--timestamp", "--force","--deep", "--sign", "Developer ID Application", resourcesPath.get().asFile)
432437
doLast {
433438
jars.forEach { file ->
434439
zipTo(file.resolve(file.nameWithoutExtension), file)

0 commit comments

Comments
 (0)