Merge pull request #48959 from Karm/issue-48946

Avoids some WARNINGs from io.smallrye.common.process.Logging

Author: geoand

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildContainerRunner.java

@@ -104,7 +104,8 @@ private void pull(String effectiveBuilderImage, boolean processInheritIODisabled
             pb.output().inherited().error().inherited();
         }
         try {
-            pb.run();
+            // logOnSuccess(false) avoids WARNING from io.smallrye.common.process.Logging
+            pb.error().logOnSuccess(false).run();
         } catch (Exception e) {
             throw new RuntimeException("Failed to pull builder image '" + effectiveBuilderImage + "'", e);
         }

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunner.java

@@ -71,7 +71,9 @@ public void build(List<String> args, String nativeImageName, String resultingExe
                         }
                     })
                     .output().consumeLinesWith(8192, log::info)
-                    .error().consumeWith(br -> new ErrorReplacingProcessReader(br, outputDir.resolve("reports").toFile()).run())
+                    // Why logOnSuccess(false) and then consumeWith? Because we get the stdErr twice otherwise.
+                    .error().logOnSuccess(false)
+                    .consumeWith(br -> new ErrorReplacingProcessReader(br, outputDir.resolve("reports").toFile()).run())
                     .run();
             boolean objcopyExists = objcopyExists();
 
@@ -121,12 +123,13 @@ protected void postBuild(Path outputDir, String nativeImageName, String resultin
     static void runCommand(String[] command, String errorMsg, File workingDirectory) {
         log.info(String.join(" ", command).replace("$", "\\$"));
         try {
-            var pb = ProcessBuilder.newBuilder(command[0])
+            final ProcessBuilder<Void> pb = ProcessBuilder.newBuilder(command[0])
                     .arguments(Arrays.copyOfRange(command, 1, command.length));
             if (workingDirectory != null) {
                 pb.directory(workingDirectory.toPath());
             }
-            pb.run();
+            // Without logOnSuccess(false) the error stream is printed twice and with a "WARNING".
+            pb.error().logOnSuccess(false).run();
         } catch (Exception e) {
             if (errorMsg != null) {
                 log.errorf(e, errorMsg);

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

@@ -1,6 +1,7 @@
 package io.quarkus.deployment.pkg.steps;
 
 import static io.quarkus.deployment.builditem.nativeimage.UnsupportedOSBuildItem.Arch.AMD64;
+import static io.smallrye.common.process.ProcessBuilder.newBuilder;
 
 import java.io.File;
 import java.io.IOException;
@@ -59,7 +60,6 @@
 import io.quarkus.sbom.ApplicationManifestConfig;
 import io.smallrye.common.os.OS;
 import io.smallrye.common.process.AbnormalExitException;
-import io.smallrye.common.process.ProcessBuilder;
 import io.smallrye.common.process.ProcessUtil;
 
 public class NativeImageBuildStep {
@@ -566,7 +566,8 @@ private static String detectPIE() {
 
     private static String testGCCArgument(String argument) {
         try {
-            ProcessBuilder.exec("cc", "-v", "-E", argument, "-");
+            newBuilder("cc", "-v", "-E", argument, "-")
+                    .error().logOnSuccess(log.isTraceEnabled()).run();
             return argument;
         } catch (Exception ignored) {
             return "";