Skip to content

Conversation

thorsteneckel
Copy link
Contributor

As requested by @sikachu in #151 I added a block to the README on how to mitigate CVE-2015-9284 by converting insecurely stored session IDs by running an Active Record Migration including an example and remark for custom Session classes.

cc @rafaelfranca

Copy link
Contributor

@kratob kratob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! ❤️

Co-authored-by: Tobias Kraze <[email protected]>
Copy link
Member

@sikachu sikachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things that I want to touch up on this documentation, but I don't think it's worth blocking the PR for it. I think I can work on them on a follow-up commit.

Overall, I think this looks good for me.

@sikachu sikachu merged commit c16ddd2 into rails:master Mar 10, 2021
information into the log, and it is required for security reason.

## Contributing to Active Record Session Store
CVE-2015-9284 mitigation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thorsteneckel was this just a mistake or does CVE-2015-9284 have any connection to CVE-2019-25025 ?

This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants