Extract common logic to a shared method

Author: rafaelfranca

lib/propshaft/asset.rb

@@ -4,6 +4,15 @@
 class Propshaft::Asset
   attr_reader :path, :logical_path, :load_path
 
+  class << self
+    def extract_path_and_digest(digested_path)
+      digest    = digested_path[/-([0-9a-zA-Z]{7,128})\.(?!digested)([^.]|.map)+\z/, 1]
+      path      = digest ? digested_path.sub("-#{digest}", "") : digested_path
+
+      [path, digest]
+    end
+  end
+
   def initialize(path, logical_path:, load_path:)
     @path, @logical_path, @load_path = path, Pathname.new(logical_path), load_path
   end

lib/propshaft/output_path.rb

@@ -26,7 +26,7 @@ def files
     Hash.new.tap do |files|
       all_files_from_tree(path).each do |file|
         digested_path = file.relative_path_from(path)
-        logical_path, digest = extract_path_and_digest(digested_path)
+        logical_path, digest = Propshaft::Asset.extract_path_and_digest(digested_path.to_s)
 
         files[digested_path.to_s] = {
           logical_path: logical_path.to_s,
@@ -42,7 +42,7 @@ def fresh_version_within_limit(mtime, count, expires_at:, limit:)
       modified_at = [ 0, Time.now - mtime ].max
       modified_at < expires_at || limit < count
     end
-  
+
     def remove(path)
       FileUtils.rm(@path.join(path))
       Propshaft.logger.info "Removed #{path}"
@@ -51,11 +51,4 @@ def remove(path)
     def all_files_from_tree(path)
       path.children.flat_map { |child| child.directory? ? all_files_from_tree(child) : child }
     end
-
-    def extract_path_and_digest(digested_path)
-      digest = digested_path.to_s[/-([0-9a-f]{7,128})\.(?!digested)/, 1]
-      path = digest ? digested_path.sub("-#{digest}", "") : digested_path
-
-      [path, digest]
-    end
 end

lib/propshaft/server.rb

@@ -35,10 +35,8 @@ def inspect
   private
     def extract_path_and_digest(env)
       full_path = Rack::Utils.unescape(env["PATH_INFO"].to_s.sub(/^\//, ""))
-      digest    = full_path[/-([0-9a-zA-Z]{7,128})\.(?!digested)([^.]|.map)+\z/, 1]
-      path      = digest ? full_path.sub("-#{digest}", "") : full_path
 
-      [ path, digest ]
+      Propshaft::Asset.extract_path_and_digest(full_path)
     end
 
     if Gem::Version.new(Rack::RELEASE) < Gem::Version.new("3")

test/propshaft/output_path_test.rb

@@ -54,10 +54,13 @@ class Propshaft::OutputPathTest < ActiveSupport::TestCase
     old     = output_asset("by_count.txt.map", "old", created_at: Time.now - 300)
     current = output_asset("by_count.txt.map", "current", created_at: Time.now - 180)
 
+    assert File.exist?(current)
+    assert File.exist?(old)
+
     @output_path.clean(1, 0)
 
     assert File.exist?(current)
-    assert_not File.exist?(old)
+    assert_not File.exist?(old), "#{old} should not exist"
   ensure
     FileUtils.rm(old) if File.exist?(old)
     FileUtils.rm(current) if File.exist?(current)