From 64bd9593acc9ddc189f360f0bb99fcdaafd35a8c Mon Sep 17 00:00:00 2001 From: Pavel V Date: Sat, 9 Mar 2019 02:16:20 +0300 Subject: [PATCH 1/4] Iterate using for in --- src/bindActionCreators.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/bindActionCreators.js b/src/bindActionCreators.js index 7a0d950cc3..0e47477def 100644 --- a/src/bindActionCreators.js +++ b/src/bindActionCreators.js @@ -39,10 +39,8 @@ export default function bindActionCreators(actionCreators, dispatch) { ) } - const keys = Object.keys(actionCreators) const boundActionCreators = {} - for (let i = 0; i < keys.length; i++) { - const key = keys[i] + for (const key in actionCreators) { const actionCreator = actionCreators[key] if (typeof actionCreator === 'function') { boundActionCreators[key] = bindActionCreator(actionCreator, dispatch) From c0f1a0117824272637ffb796932678443f83d672 Mon Sep 17 00:00:00 2001 From: Pavel V Date: Sat, 9 Mar 2019 02:20:26 +0300 Subject: [PATCH 2/4] Use single quotes for string literals without interpolation --- src/applyMiddleware.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applyMiddleware.js b/src/applyMiddleware.js index 4a2a4e97b7..3bfc647b45 100644 --- a/src/applyMiddleware.js +++ b/src/applyMiddleware.js @@ -21,8 +21,8 @@ export default function applyMiddleware(...middlewares) { const store = createStore(...args) let dispatch = () => { throw new Error( - `Dispatching while constructing your middleware is not allowed. ` + - `Other middleware would not be applied to this dispatch.` + 'Dispatching while constructing your middleware is not allowed. ' + + 'Other middleware would not be applied to this dispatch.' ) } From a3c39464d03309df7f146b67bc3bfffb1d7a336e Mon Sep 17 00:00:00 2001 From: Pavel V Date: Sat, 9 Mar 2019 02:20:50 +0300 Subject: [PATCH 3/4] Fix punctuation. --- src/createStore.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/createStore.js b/src/createStore.js index 70d83932e6..c5ce5c0c01 100644 --- a/src/createStore.js +++ b/src/createStore.js @@ -36,7 +36,7 @@ export default function createStore(reducer, preloadedState, enhancer) { throw new Error( 'It looks like you are passing several store enhancers to ' + 'createStore(). This is not supported. Instead, compose them ' + - 'together to a single function' + 'together to a single function.' ) } From 235aa07c546ccb5a9ee9b63aaf678c5c9ac5c6bd Mon Sep 17 00:00:00 2001 From: Tim Dorr Date: Fri, 8 Mar 2019 20:46:40 -0500 Subject: [PATCH 4/4] Limit node version until we update jest. --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 8f5e52c523..240018726d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,6 @@ language: node_js node_js: - - "node" + - "11.10.1" install: - npm i -g npm@5.8.0 - npm ci