Skip to content

Commit aaef0b7

Browse files
authored
Fix broken example source links in Viewer example list (#6451)
### What * Fixes #6425 Tested using `cargo run -p re_dev_tools -- build-examples manifest --channel nightly test.json` and then trying a few links inside the manifest ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6451?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6451?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6451) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
1 parent 5561df4 commit aaef0b7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

crates/re_dev_tools/src/build_examples/example.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ use std::str::FromStr;
99
use anyhow::Context;
1010

1111
pub struct Example {
12+
/// Name of the folder it's stored in.
1213
pub name: String,
1314
pub title: String,
1415
pub dir: PathBuf,

crates/re_dev_tools/src/build_examples/manifest.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,8 @@ impl ManifestEntry {
8585
height: example.thumbnail_dimensions[1],
8686
},
8787
source_url: format!(
88-
"{base_source_url}/examples/{}/{name}/{}",
88+
"{base_source_url}/examples/{}/{name}",
8989
example.language.examples_dir().to_string_lossy(),
90-
example.script_path.to_string_lossy(),
9190
),
9291
name,
9392
}

0 commit comments

Comments
 (0)