add top markets, currencies endpoints

shekenahglory · shekenahglory · commit 47da51a4909a · 2016-01-19T14:31:34.000-08:00
diff --git a/api/routesV2/network/index.js b/api/routesV2/network/index.js
@@ -3,6 +3,8 @@ module.exports = function(db) {
   return {
     exchangeVolume: getMetric.bind(undefined, 'trade_volume'),
     paymentVolume: getMetric.bind(undefined, 'payment_volume'),
-    issuedValue: getMetric.bind(undefined, 'issued_value')
+    issuedValue: getMetric.bind(undefined, 'issued_value'),
+    topMarkets: require('./topMarkets')(db),
+    topCurrencies: require('./topCurrencies')(db)
   }
 };
diff --git a/api/routesV2/network/topCurrencies.js b/api/routesV2/network/topCurrencies.js
@@ -0,0 +1,85 @@
+'use strict';
+
+var Logger = require('../../../lib/logger');
+var log = new Logger({scope: 'top currencies'});
+var smoment = require('../../../lib/smoment');
+var utils = require('../../../lib/utils');
+var hbase;
+
+var getTopCurrencies = function(req, res) {
+  var options = {
+    date: req.params.date ? smoment(req.params.date) : undefined,
+    format: (req.query.format || 'json').toLowerCase()
+  };
+
+  if (req.params.date && !options.date) {
+    errorResponse({
+      error: 'invalid date format',
+      code: 400
+    });
+    return;
+
+  } else if (options.date) {
+    options.date.moment.startOf('day');
+  }
+
+  hbase.getTopCurrencies(options, function(err, markets) {
+    if (err) {
+      errorResponse(err);
+    } else {
+      successResponse(markets, options);
+    }
+  });
+
+
+  /**
+  * errorResponse
+  * return an error response
+  * @param {Object} err
+  */
+
+  function errorResponse(err) {
+    log.error(err.error || err);
+    if (err.code && err.code.toString()[0] === '4') {
+      res.status(err.code).json({
+        result: 'error',
+        message: err.error
+      });
+    } else {
+      res.status(500).json({
+        result: 'error',
+        message: 'unable to retrieve top currencies'
+      });
+    }
+  }
+
+  /**
+  * successResponse
+  * return a successful response
+  * @param {Object} markets
+  * @param {Object} options
+  */
+
+  function successResponse(markets, options) {
+    var date = options.date ?
+        options.date.format() : smoment().format();
+
+    if (options.format === 'csv') {
+      filename = 'top currencies - ' + date + '.csv';
+      res.csv(markets, filename);
+
+    } else {
+      res.json({
+        result: 'success',
+        date: date,
+        count: markets.length,
+        markets: markets
+      });
+    }
+  }
+};
+
+module.exports = function(db) {
+  hbase = db;
+  return getTopCurrencies;
+};
diff --git a/api/routesV2/network/topMarkets.js b/api/routesV2/network/topMarkets.js
@@ -0,0 +1,86 @@
+'use strict';
+
+var Logger = require('../../../lib/logger');
+var log = new Logger({scope: 'top markets'});
+var smoment = require('../../../lib/smoment');
+var utils = require('../../../lib/utils');
+var hbase;
+
+var getTopMarkets = function(req, res) {
+  var options = {
+    date: req.params.date ? smoment(req.params.date) : undefined,
+    format: (req.query.format || 'json').toLowerCase()
+  };
+
+  if (req.params.date && !options.date) {
+    errorResponse({
+      error: 'invalid date format',
+      code: 400
+    });
+    return;
+
+  } else if (options.date) {
+    options.date.moment.startOf('day');
+  }
+
+  hbase.getTopMarkets(options, function(err, markets) {
+    if (err) {
+      errorResponse(err);
+    } else {
+      successResponse(markets, options);
+    }
+  });
+
+
+  /**
+  * errorResponse
+  * return an error response
+  * @param {Object} err
+  */
+
+  function errorResponse(err) {
+    log.error(err.error || err);
+    if (err.code && err.code.toString()[0] === '4') {
+      res.status(err.code).json({
+        result: 'error',
+        message: err.error
+      });
+    } else {
+      res.status(500).json({
+        result: 'error',
+        message: 'unable to retrieve top markets'
+      });
+    }
+  }
+
+  /**
+  * successResponse
+  * return a successful response
+  * @param {Object} markets
+  * @param {Object} options
+  */
+
+  function successResponse(markets, options) {
+    var date = options.date ?
+        options.date.format() : smoment().format();
+    var filename;
+
+    if (options.format === 'csv') {
+      filename = 'top markets - ' + date + '.csv';
+      res.csv(markets, filename);
+
+    } else {
+      res.json({
+        result: 'success',
+        date: date,
+        count: markets.length,
+        markets: markets
+      });
+    }
+  }
+};
+
+module.exports = function(db) {
+  hbase = db;
+  return getTopMarkets;
+};
diff --git a/api/server.js b/api/server.js
@@ -55,8 +55,8 @@ var Server = function (options) {
     app.get('/v2/network/exchange_volume', routesV2.network.exchangeVolume);
     app.get('/v2/network/payment_volume', routesV2.network.paymentVolume);
     app.get('/v2/network/issued_value', routesV2.network.issuedValue);
-    //app.get('/v2/network/top_markets', routesV2.network.topMarkets);
-    //app.get('/v2/network/top_currencies', routesV2.network.topCurrencies);
+    app.get('/v2/network/top_markets/:date?', routesV2.network.topMarkets);
+    app.get('/v2/network/top_currencies/:date?', routesV2.network.topCurrencies);
     app.get('/v2/last_validated', routesV2.getLastValidated);
     app.get('/v2/transactions/', routesV2.getTransactions);
     app.get('/v2/transactions/:tx_hash', routesV2.getTransactions);
diff --git a/lib/hbase/hbase-client.js b/lib/hbase/hbase-client.js
@@ -790,52 +790,98 @@ HbaseClient.prototype.getCapitalization = function (options, callback) {
   }
 }
 
+/**
+ * getTopCurrencies
+ */
+
+HbaseClient.prototype.getTopCurrencies = function(options, callback) {
+  options.table = 'top_currencies';
+  this.getTop(options, callback);
+};
+
 /**
  * getTopMarkets
  */
 
 HbaseClient.prototype.getTopMarkets = function(options, callback) {
+  options.table = 'top_markets';
+  this.getTop(options, callback);
+};
+
+/**
+ * getTop
+ */
+
+HbaseClient.prototype.getTop = function(options, callback) {
   var self = this;
-  var date = options.date || smoment();
+  var start;
+  var end;
 
-  self.getScan({
-    table: 'top_100_market',
-    startRow: date.format('YYYYMMDD'),
-    stopRow: date.moment.add(1, 'day').format('YYYYMMDD')
+  if (options.table !== 'top_markets' &&
+     options.table !== 'top_currencies') {
+    callback('invalid table');
+    return;
+  }
 
-  }, function(err, resp) {
-    if (resp && resp.length) {
-      callback(null, formatMarkets(resp));
-    } else {
-      callback(err, resp);
-    }
+  if (options.date) {
+    start = smoment(options.date);
+    end = smoment(start);
+    end.moment.add(1, 'day');
+    getTopHelper(options.table, start, end);
 
-    function formatMarkets(list) {
-      var markets = [];
-      resp.forEach(function(market) {
-        markets.push({
-          base: {
-            currency: market.base_currency,
-            issuer: market.base_issuer
-          },
-          counter: {
-            currency: market.counter_currency,
-            issuer: market.counter_issuer
-          },
-          rank: Number(market.row_number),
-          count: Number(market.number_txn),
-          volume: market.xrp_value
-        });
-      });
+  // get the latest in the table
+  } else {
+    start = smoment();
+    end = smoment(0);
+
+    self.getScan({
+      table: options.table,
+      startRow: start.format('YYYYMMDD'),
+      stopRow: end.format('YYYYMMDD'),
+      descending: true,
+      limit: 1
+    }, function(err, resp) {
+      console.log(err, resp);
+      if (err || !resp.length) {
+        callback(err || 'no markets found');
+      } else {
+        start = smoment(resp[0].date || resp[0].close_time_human);
+        end = smoment(start);
+        end.moment.add(1, 'day');
+        getTopHelper(options.table, start, end);
+      }
+    });
+  }
 
-      markets.sort(function(a, b) {
-        return a.rank - b.rank;
-      });
+  function getTopHelper(table, start, end) {
+    self.getScan({
+      table: table,
+      startRow: start.format('YYYYMMDD'),
+      stopRow: end.format('YYYYMMDD')
+    }, function(err, resp) {
+      if (resp && resp.length) {
+        callback(null, formatResults(resp));
+      } else {
+        callback(err, resp);
+      }
 
-      return markets;
-    }
-  });
+      function formatResults(list) {
+        var results = [];
+        list.forEach(function(d) {
+          d.rank = Number(d.rank);
+          d.distinct_counterparty_count = Number(d.counterparty_count);
+
+          delete d.rowkey;
+          delete d.date;
+          delete d.close_date_human;
+          delete d.counterparty_count;
+          results.push(d);
+        });
 
+        return results;
+      }
+    });
+  }
 };
 
 /**
