Generic/ForLoopWithTestFunctionCall: consolidate tests in the main file

This commit moves the tests for the alternative `for` syntax to the main
test case file following a request during the PR review:
PHPCSStandards#235 (comment)

It also renames the subsequent test case files to keep the filenames
consistent.

Author: rodrigoprimo

src/Standards/Generic/Tests/CodeAnalysis/ForLoopWithTestFunctionCallUnitTest.1.inc

@@ -1,7 +1,5 @@
 <?php
 
-// This test case file only deals with the normal "for" loop syntax.
-
 $a = array(1, 2, 3, 4);
 for ($i = 0; $i < count($a); $i++) {
     $a[$i] *= $i;
@@ -23,3 +21,25 @@ for ($i = 0; MyClass::staticMethod($i); $i++) {
 for ($i = 0; $countFunction($i); $i++) {
     echo $i;
 }
+
+$a = array(1, 2, 3, 4);
+for ($i = 0; $i < count($a); $i++):
+    $a[$i] *= $i;
+endfor;
+
+for ($i = 0, $c = sizeof($a); $i < $c; ++$i):
+    $a[$i] *= $i;
+endfor;
+
+$it = new ArrayIterator($a);
+for ($it->rewind(); $it->valid(); $it->next()):
+    echo $it->current();
+endfor;
+
+for ($i = 0; MyClass::staticMethod($i); $i++) :
+    echo $i;
+endfor;
+
+for ($i = 0; $countFunction($i); $i++):
+    echo $i;
+endfor;

src/Standards/Generic/Tests/CodeAnalysis/ForLoopWithTestFunctionCallUnitTest.2.inc

@@ -1,25 +1,5 @@
 <?php
 
-// This test case file only deals with the alternative "for" loop syntax.
-
-$a = array(1, 2, 3, 4);
-for ($i = 0; $i < count($a); $i++):
-    $a[$i] *= $i;
-endfor;
-
-for ($i = 0, $c = sizeof($a); $i < $c; ++$i):
-    $a[$i] *= $i;
-endfor;
-
-$it = new ArrayIterator($a);
-for ($it->rewind(); $it->valid(); $it->next()):
-    echo $it->current();
-endfor;
-
-for ($i = 0; MyClass::staticMethod($i); $i++) :
-    echo $i;
-endfor;
-
-for ($i = 0; $countFunction($i); $i++):
-    echo $i;
-endfor;
+// Intentional parse error (missing open parenthesis). Testing that the sniff is *not* triggered
+// in this case and that no PHP 8.3+ deprecation notice is thrown.
+for

src/Standards/Generic/Tests/CodeAnalysis/ForLoopWithTestFunctionCallUnitTest.3.inc

@@ -1,5 +1,6 @@
 <?php
 
-// Intentional parse error (missing open parenthesis). Testing that the sniff is *not* triggered
+// Similar to issue PHPCSStandards/PHP_CodeSniffer#226
+// Intentional parse error (missing close parenthesis). Testing that the sniff is *not* triggered
 // in this case and that no PHP 8.3+ deprecation notice is thrown.
-for
+for ($i = 0; $i < count($a); $i++

src/Standards/Generic/Tests/CodeAnalysis/ForLoopWithTestFunctionCallUnitTest.4.inc

@@ -49,12 +49,15 @@ public function getWarningList($testFile='')
     {
         switch ($testFile) {
         case 'ForLoopWithTestFunctionCallUnitTest.1.inc':
-        case 'ForLoopWithTestFunctionCallUnitTest.2.inc':
             return [
-                6  => 1,
-                15 => 1,
-                19 => 1,
-                23 => 1,
+                4  => 1,
+                13 => 1,
+                17 => 1,
+                21 => 1,
+                26 => 1,
+                35 => 1,
+                39 => 1,
+                43 => 1,
             ];
         default:
             return [];