Rollup merge of #146738 - beepster4096:widnows, r=jieyouxu

jhpratt · web-flow · commit 795550cc85f6 · 2025-09-18T23:17:59.000-04:00
Fix tidy spellchecking on Windows

Tidy should now check for executable with the right extension for the platform when installing tools
diff --git a/src/tools/tidy/src/lib.rs b/src/tools/tidy/src/lib.rs
@@ -237,7 +237,7 @@ pub fn ensure_version_or_cargo_install(
     if !cargo_exit_code.success() {
         return Err(io::Error::other("cargo install failed"));
     }
-    let bin_path = tool_bin_dir.join(bin_name);
+    let bin_path = tool_bin_dir.join(bin_name).with_extension(env::consts::EXE_EXTENSION);
     assert!(
         matches!(bin_path.try_exists(), Ok(true)),
         "cargo install did not produce the expected binary"

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ pub fn ensure_version_or_cargo_install(`
`237`	`237`	`if !cargo_exit_code.success() {`
`238`	`238`	`return Err(io::Error::other("cargo install failed"));`
`239`	`239`	`}`
`240`		`- let bin_path = tool_bin_dir.join(bin_name);`
	`240`	`+ let bin_path = tool_bin_dir.join(bin_name).with_extension(env::consts::EXE_EXTENSION);`
`241`	`241`	`assert!(`
`242`	`242`	`matches!(bin_path.try_exists(), Ok(true)),`
`243`	`243`	`"cargo install did not produce the expected binary"`