Skip to content

Commit 8072151

Browse files
Closes #5164
1 parent 385b4d1 commit 8072151

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

ChangeLog-9.6.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
All notable changes of the PHPUnit 9.6 release series are documented in this file using the [Keep a CHANGELOG](https://keepachangelog.com/) principles.
44

5+
## [9.6.3] - 2023-MM-DD
6+
7+
### Fixed
8+
9+
* [#5164](https://github.com/sebastianbergmann/phpunit/issues/5164): `markTestSkipped()` not handled correctly when called in "before first test" method
10+
511
## [9.6.2] - 2023-02-04
612

713
### Fixed
@@ -24,6 +30,7 @@ All notable changes of the PHPUnit 9.6 release series are documented in this fil
2430
* [#5064](https://github.com/sebastianbergmann/phpunit/issues/5064): Deprecate `PHPUnit\Framework\TestCase::getMockClass()`
2531
* [#5132](https://github.com/sebastianbergmann/phpunit/issues/5132): Deprecate `Test` suffix for abstract test case classes
2632

33+
[9.6.3]: https://github.com/sebastianbergmann/phpunit/compare/9.6.2...9.6
2734
[9.6.2]: https://github.com/sebastianbergmann/phpunit/compare/9.6.1...9.6.2
2835
[9.6.1]: https://github.com/sebastianbergmann/phpunit/compare/9.6.0...9.6.1
2936
[9.6.0]: https://github.com/sebastianbergmann/phpunit/compare/9.5.28...9.6.0

src/Framework/TestSuite.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ public function run(TestResult $result = null): TestResult
628628
call_user_func([$this->name, $beforeClassMethod]);
629629
}
630630
}
631-
} catch (SkippedTestSuiteError $error) {
631+
} catch (SkippedTestSuiteError|SkippedTestError $error) {
632632
foreach ($this->tests() as $test) {
633633
$result->startTest($test);
634634
$result->addFailure($test, $error, 0);

tests/end-to-end/regression/5164.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ $_SERVER['argv'][] = __DIR__ . '/5164/Issue5164Test.php';
99

1010
require_once __DIR__ . '/../../bootstrap.php';
1111
PHPUnit\TextUI\Command::main();
12-
--XFAIL--
13-
https://github.com/sebastianbergmann/phpunit/issues/5164
1412
--EXPECTF--
1513
PHPUnit %s by Sebastian Bergmann and contributors.
1614

0 commit comments

Comments
 (0)