refactor(model): remove unnecessary code for slice length check (#68)

Signed-off-by: lsytj0413 <[email protected]>

Signed-off-by: lsytj0413 <[email protected]>

Author: lsytj0413

go.sum

@@ -44,7 +44,6 @@ github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9dec
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
-golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3 h1:0es+/5331RGQPcXlMfP+WrnIIS6dNnNRe0WB02W0F4M=
 golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
 golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d h1:3qF+Z8Hkrw9sOhrFHti9TlB1Hkac1x+DNRkv0XQiFjo=
 golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=

model/auth.go

@@ -31,13 +31,12 @@ func init() {
 func AuthDefinitionsStructLevelValidation(structLevel validator.StructLevel) {
 	authDefs := structLevel.Current().Interface().(AuthDefinitions)
 	dict := map[string]bool{}
-	if authDefs.Defs != nil && len(authDefs.Defs) > 1 {
-		for _, a := range authDefs.Defs {
-			if !dict[a.Name] {
-				dict[a.Name] = true
-			} else {
-				structLevel.ReportError(reflect.ValueOf(a.Name), "Name", "name", "reqnameunique", "")
-			}
+
+	for _, a := range authDefs.Defs {
+		if !dict[a.Name] {
+			dict[a.Name] = true
+		} else {
+			structLevel.ReportError(reflect.ValueOf(a.Name), "Name", "name", "reqnameunique", "")
 		}
 	}
 }

model/auth_test.go

@@ -0,0 +1,94 @@
+// Copyright 2021 The Serverless Workflow Specification Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package model
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	val "github.com/serverlessworkflow/sdk-go/v2/validator"
+)
+
+func TestAuthDefinitionsStructLevelValidation(t *testing.T) {
+	type testCase struct {
+		desp     string
+		authDefs AuthDefinitions
+		err      string
+	}
+	testCases := []testCase{
+		{
+			desp: "nil defs",
+			authDefs: AuthDefinitions{
+				Defs: nil,
+			},
+			err: ``,
+		},
+		{
+			desp: "zero length defs",
+			authDefs: AuthDefinitions{
+				Defs: []Auth{},
+			},
+			err: ``,
+		},
+		{
+			desp: "multi unique defs",
+			authDefs: AuthDefinitions{
+				Defs: []Auth{
+					{
+						Name: "1",
+					},
+					{
+						Name: "2",
+					},
+					{
+						Name: "3",
+					},
+				},
+			},
+			err: ``,
+		},
+		{
+			desp: "multi non-unique defs",
+			authDefs: AuthDefinitions{
+				Defs: []Auth{
+					{
+						Name: "1",
+					},
+					{
+						Name: "2",
+					},
+					{
+						Name: "1",
+					},
+				},
+			},
+			err: `Key: 'AuthDefinitions.Name' Error:Field validation for 'Name' failed on the 'reqnameunique' tag`,
+		},
+	}
+	for _, tc := range testCases {
+		t.Run(tc.desp, func(t *testing.T) {
+			err := val.GetValidator().Struct(tc.authDefs)
+
+			if tc.err != "" {
+				assert.Error(t, err)
+				assert.Regexp(t, tc.err, err)
+				return
+			}
+
+			assert.NoError(t, err)
+		})
+	}
+}