address integer typo for auth

Author: spolti

model/auth.go

@@ -100,18 +100,35 @@ func (a *AuthDefinitions) UnmarshalJSON(b []byte) error {
 		return fmt.Errorf("no bytes to unmarshal")
 	}
 
-	// See if we can guess based on the first character
-	switch b[0] {
-	case '"':
-		return a.unmarshalFile(b)
-	case '[':
-		return a.unmarshalMany(b)
-	case '{': // single values are not supported, should we support it?
-		return fmt.Errorf("authDefinitions value '%s' is not supported, it must be an object or string", string(b))
-	default:
-		// nil can be returned as both cases are returning errors in case of unmarshal problem.
-		return nil
+	for index, char := range b {
+
+		switch {
+		case b[index] >= '0' && b[index] <= '9':
+			fmt.Print(string(char))
+			return fmt.Errorf("authDefinitions value '%s' is not supported, it must be an object or string", string(b))
+
+		case b[index] == '"':
+			return a.unmarshalFile(b)
+		case b[index] == '[':
+			return a.unmarshalMany(b)
+		case b[index] == '{': // single values are not supported, should we support it?
+			return fmt.Errorf("authDefinitions value '%s' is not supported, it must be an object or string", string(b))
+		}
 	}
+	return nil
+	// See if we can guess based on the first character
+	// switch b[0] {
+	// case '"':
+	// 	return a.unmarshalFile(b)
+	// case '[':
+	// 	return a.unmarshalMany(b)
+	// case '{': // single values are not supported, should we support it?
+	// 	return fmt.Errorf("authDefinitions value '%s' is not supported, it must be an object or string", string(b))
+	//
+	// default:
+	// 	// nil can be returned as both cases are returning errors in case of unmarshal problem.
+	// 	return nil
+	// }
 }
 
 func (a *AuthDefinitions) unmarshalFile(data []byte) error {

parser/parser_test.go

@@ -496,3 +496,98 @@ func TestFromFile(t *testing.T) {
 		)
 	}
 }
+
+func TestUnmarshalWorkflowBasicTests(t *testing.T) {
+	t.Run("BasicWorkflowYamlNoAuthDefs", func(t *testing.T) {
+		workflow, err := FromYAMLSource([]byte(`
+id: helloworld
+version: '1.0.0'
+specVersion: '0.8'
+name: Hello World Workflow
+description: Inject Hello World
+start: Hello State
+states:
+- name: Hello State
+  type: inject
+  data:
+    result: Hello World!
+  end: true
+`))
+		assert.Nil(t, err)
+		assert.NotNil(t, workflow)
+	})
+
+	t.Run("BasicWorkflowBasicAuthJSONSource", func(t *testing.T) {
+		workflow, err := FromJSONSource([]byte(`
+{
+  "id": "applicantrequest",
+  "version": "1.0",
+  "name": "Applicant Request Decision Workflow",
+  "description": "Determine if applicant request is valid",
+  "start": "CheckApplication",
+  "specVersion": "0.7",
+  "auth": [
+    {
+      "name": "testAuth",
+      "scheme": "bearer",
+      "properties": {
+        "token": "test_token"
+      }
+    },
+    {
+      "name": "testAuth2",
+      "scheme": "basic",
+      "properties": {
+        "username": "test_user",
+        "password": "test_pwd"
+      }
+    }
+  ],
+  "states": [
+    {
+	  "name": "Hello State",
+	  "type": "inject",
+      "data": {
+		"result": "Hello World!"
+	  },
+	  "end": true
+    }
+  ]
+}
+`))
+		assert.Nil(t, err)
+		assert.NotNil(t, workflow)
+
+		// TODO verify it
+		// b, _ := json.Marshal(workflow)
+		// assert.False(t, strings.Contains(string(b), "defs"), "defs should be in the marshalled workflow.")
+
+	})
+
+	t.Run("BasicWorkflowInteger", func(t *testing.T) {
+		workflow, err := FromJSONSource([]byte(`
+{
+  "id": "applicantrequest",
+  "version": "1.0",
+  "name": "Applicant Request Decision Workflow",
+  "description": "Determine if applicant request is valid",
+  "start": "CheckApplication",
+  "specVersion": "0.7",
+  "auth": 123,
+  "states": [
+    {
+	  "name": "Hello State",
+	  "type": "inject",
+      "data": {
+		"result": "Hello World!"
+	  },
+	  "end": true
+    }
+  ]
+}
+`))
+		assert.NotNil(t, err)
+		assert.Nil(t, workflow)
+
+	})
+}

parser/testdata/workflows/applicationrequest.multiauth.json

@@ -21,8 +21,7 @@
         "password": "test_pwd"
       }
     }
-  ]
-  ,
+  ],
   "functions": [
     {
       "name": "sendRejectionEmailFunction",