Skip to content

Commit c54c6bd

Browse files
committed
change width of navbar collapse; fixes daattali#719
1 parent d585986 commit c54c6bd

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## Unreleased version
2+
3+
- Changed the width at which the navbar collapses to a higher threshold because most modern non-mobile browsers are >1000px
4+
15
## v5.0.0 (2020-09-15)
26

37
One of the major changes in this version is that a lot of time was spent on rethinking the entire SEO and social media sharing model (how a page looks on eg. Google, Twitter, Facebok). It was redesigned to be more simple and customizable. The new documentation has a section dedicated to SEO and social media sharing of a page. Unfortunately some changes that are not backwards-compatible had to be made.

_includes/nav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<nav class="navbar navbar-expand-md navbar-light fixed-top navbar-custom {% if page.nav-short %}top-nav-short-permanent{% else %}top-nav-regular{% endif %}">
1+
<nav class="navbar navbar-expand-lg navbar-light fixed-top navbar-custom {% if page.nav-short %}top-nav-short-permanent{% else %}top-nav-regular{% endif %}">
22

33
{%- if site.title-img -%}
44
<a class="navbar-brand navbar-brand-logo" href="{{ '' | absolute_url }}"><img alt="{{ site.title }} Logo" src="{{ site.title-img }}"/></a>

assets/css/beautifuljekyll.css

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,6 @@ hr.small {
7575
margin: -3.125rem 0 0;
7676
}
7777

78-
.main-content {
79-
padding-top: 5rem;
80-
}
81-
@media (min-width: 768px) {
82-
.main-content {
83-
padding-top: 8.125rem;
84-
}
85-
}
86-
8778
.hideme {
8879
display: none;
8980
}
@@ -228,7 +219,7 @@ img {
228219
border-width: 0.4em;
229220
}
230221

231-
@media (min-width: 768px) {
222+
@media (min-width: 992px) {
232223
.navbar-custom {
233224
padding-top: 1.25rem;
234225
padding-bottom: 1.25rem;
@@ -243,17 +234,17 @@ img {
243234
height: 3.125rem;
244235
}
245236

246-
.navbar-expand-md .navbar-nav .nav-link {
237+
.navbar-expand-lg .navbar-nav .nav-link {
247238
padding-left: 0.9375rem;
248239
padding-right: 0.9375rem;
249240
}
250241

251-
.navbar-expand-md .navbar-nav .nav-item:not(.dropdown):last-child .nav-link {
242+
.navbar-expand-lg .navbar-nav .nav-item:not(.dropdown):last-child .nav-link {
252243
padding-right: 0;
253244
}
254245
}
255246

256-
@media (min-width: 768px) {
247+
@media (min-width: 992px) {
257248
.navbar-custom .nav-item.dropdown:hover {
258249
background: rgba(0, 0, 0, 0.1);
259250
}
@@ -281,7 +272,7 @@ img {
281272
font-weight: normal;
282273
}
283274

284-
@media (min-width: 768px) {
275+
@media (min-width: 992px) {
285276
.navbar-custom .nav-item.dropdown .dropdown-menu {
286277
text-align: center;
287278
}
@@ -293,7 +284,7 @@ img {
293284
}
294285
}
295286

296-
@media (max-width: 767px) {
287+
@media (max-width: 991px) {
297288
.navbar-custom .navbar-collapse {
298289
border-top: 1px solid {{ site.navbar-border-col | default: "#DDDDDD" }};
299290
margin: 0 -1rem;
@@ -355,7 +346,7 @@ img {
355346
display: none;
356347
}
357348

358-
@media (min-width: 768px) {
349+
@media (min-width: 992px) {
359350
.navbar-custom.top-nav-regular .avatar-container {
360351
width: 6.25rem;
361352
}
@@ -701,7 +692,7 @@ nav.top-nav-short-permanent ~ header > .intro-header.big-img {
701692
bottom: 0;
702693
display: none;
703694
}
704-
@media (min-width: 768px) {
695+
@media (min-width: 992px) {
705696
.intro-header {
706697
margin-top: 8.125rem;
707698
}

0 commit comments

Comments
 (0)