fix google scholar link construction (daattali#1187) (daattali#1189)

Author: crypdick

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Unreleased version
 
 - BREAKING CHANGE: Allow changing the order of the social network links that appear in the footer (#1152)
+- BREAKING CHANGE: `google-scholar` social network link no longer requires the prefix `citations?user=`; if you previously set this parameter, it needs to be updated (#1189)  
 - Fixed bug where hovering over search results showed the text "{desc}" (#1156) 
 - Added social network links for GitLab, Bluesky (#1168, #1218)
 - Added instructions and example on how to fix image links in project sites (#1171)

_includes/social-networks-links.html

@@ -281,7 +281,7 @@
 
   {%- if network[0] == "google-scholar" -%}
   <li class="list-inline-item">
-    <a href="https://scholar.google.com/{{ network[1] }}" title="Google Scholar">
+    <a href="https://scholar.google.com/citations?user={{ network[1] }}" title="Google Scholar">
       <span class="fa-stack fa-lg" aria-hidden="true">
         <i class="fas fa-circle fa-stack-2x"></i>
         <i class="fa fa-graduation-cap fa-stack-1x fa-inverse"></i>