Skip to content

Commit 44965f0

Browse files
committed
dont duplicate ModelOne; block A005
this is already in the fixtures. block new flake8 A005 warning nobody asked for Change-Id: Ic4f3ec3d1eee5333edb3f48ac95b09ad1b8fdbdf
1 parent 0bc8c63 commit 44965f0

File tree

2 files changed

+2
-99
lines changed

2 files changed

+2
-99
lines changed

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ where = tests
8484
enable-extensions = G
8585
# E203 is due to https://github.com/PyCQA/pycodestyle/issues/373
8686
ignore =
87-
A003,
87+
A003,A005
8888
D,
8989
E203,E305,E704,E711,E712,E721,E722,E741,
9090
N801,N802,N806,

tests/test_autogen_diffs.py

Lines changed: 1 addition & 98 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
from alembic.testing.suite._autogen_fixtures import _default_object_filters
5656
from alembic.testing.suite._autogen_fixtures import AutogenFixtureTest
5757
from alembic.testing.suite._autogen_fixtures import AutogenTest
58+
from alembic.testing.suite._autogen_fixtures import ModelOne
5859
from alembic.util import CommandError
5960

6061
# TODO: we should make an adaptation of CompareMetadataToInspectorTest that is
@@ -315,104 +316,6 @@ def _include_object(obj, name, type_, reflected, compare_to):
315316
eq_(len(diffs), 0)
316317

317318

318-
class ModelOne:
319-
__requires__ = ("unique_constraint_reflection",)
320-
321-
schema = None
322-
323-
@classmethod
324-
def _get_db_schema(cls):
325-
schema = cls.schema
326-
327-
m = MetaData(schema=schema)
328-
329-
Table(
330-
"user",
331-
m,
332-
Column("id", Integer, primary_key=True),
333-
Column("name", String(50)),
334-
Column("a1", Text),
335-
Column("pw", String(50)),
336-
Index("pw_idx", "pw"),
337-
)
338-
339-
Table(
340-
"address",
341-
m,
342-
Column("id", Integer, primary_key=True),
343-
Column("email_address", String(100), nullable=False),
344-
)
345-
346-
Table(
347-
"order",
348-
m,
349-
Column("order_id", Integer, primary_key=True),
350-
Column(
351-
"amount",
352-
Numeric(8, 2),
353-
nullable=False,
354-
server_default=text("0"),
355-
),
356-
CheckConstraint("amount >= 0", name="ck_order_amount"),
357-
)
358-
359-
Table(
360-
"extra",
361-
m,
362-
Column("x", CHAR),
363-
Column("uid", Integer, ForeignKey("user.id")),
364-
)
365-
366-
return m
367-
368-
@classmethod
369-
def _get_model_schema(cls):
370-
schema = cls.schema
371-
372-
m = MetaData(schema=schema)
373-
374-
Table(
375-
"user",
376-
m,
377-
Column("id", Integer, primary_key=True),
378-
Column("name", String(50), nullable=False),
379-
Column("a1", Text, server_default="x"),
380-
)
381-
382-
Table(
383-
"address",
384-
m,
385-
Column("id", Integer, primary_key=True),
386-
Column("email_address", String(100), nullable=False),
387-
Column("street", String(50)),
388-
UniqueConstraint("email_address", name="uq_email"),
389-
)
390-
391-
Table(
392-
"order",
393-
m,
394-
Column("order_id", Integer, primary_key=True),
395-
Column(
396-
"amount",
397-
Numeric(10, 2),
398-
nullable=True,
399-
server_default=text("0"),
400-
),
401-
Column("user_id", Integer, ForeignKey("user.id")),
402-
CheckConstraint("amount > -1", name="ck_order_amount"),
403-
)
404-
405-
Table(
406-
"item",
407-
m,
408-
Column("id", Integer, primary_key=True),
409-
Column("description", String(100)),
410-
Column("order_id", Integer, ForeignKey("order.order_id")),
411-
CheckConstraint("len(description) > 5"),
412-
)
413-
return m
414-
415-
416319
class AutogenerateDiffTest(ModelOne, AutogenTest, TestBase):
417320
__only_on__ = "sqlite"
418321

0 commit comments

Comments
 (0)