Skip to content

Commit d413bb8

Browse files
committed
add comments, remove todo
1 parent 0e6244c commit d413bb8

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

rust/operator-binary/src/config/command.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,20 +175,16 @@ pub fn controller_kafka_container_command(
175175
}
176176

177177
fn to_listeners(port: u16) -> String {
178-
// TODO:
179-
// - document that variables are set in stateful set
180-
// - customize listener (CONTROLLER / CONTROLLER_AUTH?)
178+
// The environment variables are set in the statefulset of the controller
181179
format!(
182180
"{listener_name}://$POD_NAME.$ROLEGROUP_REF.$NAMESPACE.svc.$CLUSTER_DOMAIN:{port}",
183181
listener_name = KafkaListenerName::Controller
184182
)
185183
}
186184

187185
fn to_listener_security_protocol_map(kafka_listeners: &KafkaListenerConfig) -> String {
188-
// TODO: make configurable - CONTROLLER_AUTH
189186
kafka_listeners
190187
.listener_security_protocol_map_for_listener(&KafkaListenerName::Controller)
191-
// todo better error
192188
.unwrap_or("".to_string())
193189
}
194190

rust/operator-binary/src/crd/role/controller.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ pub const CONTROLLER_PROPERTIES_FILE: &str = "controller.properties";
4242
#[strum(serialize_all = "kebab-case")]
4343
pub enum ControllerContainer {
4444
Vector,
45-
// TODO: Kafka, Kraft, Controller?
4645
Kafka,
4746
}
4847

0 commit comments

Comments
 (0)