Implement getPathSegAtLength in JavaScript #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of rendering edges), is deprecated. This means that the graph explorer would render with no edges in Chrome 62 (current in the dev channel) and would thus be very much broken in Chrome 62. This commit pre-empts that change by implementing the functionality of getPathSegAtLength in the graph explorer so that the explorer still works in Chrome 62. I do not see alternative ways of implementing this functionality using the native pathLength property + getTotalLength() and getPointAtLength() methods still provided by the SVG API. After this change goes in, we should quickly release a new pypi package and internal version of TensorBoard so that the graph explorer is not broken for users of Chrome 62. Fixes #425.
jart
approved these changes
Aug 30, 2017
jart
pushed a commit
to jart/tensorboard
that referenced
this pull request
Sep 6, 2017
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of rendering edges), is deprecated. This means that the graph explorer would render with no edges in Chrome 62 (current in the dev channel) and would thus be very much broken in Chrome 62. This commit pre-empts that change by implementing the functionality of getPathSegAtLength in the graph explorer so that the explorer still works in Chrome 62. I do not see alternative ways of implementing this functionality using the native pathLength property + getTotalLength() and getPointAtLength() methods still provided by the SVG API. After this change goes in, we should quickly release a new pypi package and internal version of TensorBoard so that the graph explorer is not broken for users of Chrome 62. Fixes tensorflow#425.
jart
pushed a commit
that referenced
this pull request
Sep 6, 2017
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of rendering edges), is deprecated. This means that the graph explorer would render with no edges in Chrome 62 (current in the dev channel) and would thus be very much broken in Chrome 62. This commit pre-empts that change by implementing the functionality of getPathSegAtLength in the graph explorer so that the explorer still works in Chrome 62. I do not see alternative ways of implementing this functionality using the native pathLength property + getTotalLength() and getPointAtLength() methods still provided by the SVG API. After this change goes in, we should quickly release a new pypi package and internal version of TensorBoard so that the graph explorer is not broken for users of Chrome 62. Fixes #425.
This was referenced Dec 6, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of
rendering edges), is deprecated. This means that the graph explorer
would render with no edges in Chrome 62 (current in the dev channel) and
would thus be very much broken in Chrome 62.
This commit pre-empts that change by implementing the functionality of
getPathSegAtLength in the graph explorer so that the explorer still
works in Chrome 62.
I do not see alternative ways of implementing this functionality using
the native pathLength property + getTotalLength() and getPointAtLength()
methods still provided by the SVG API.
After this change goes in, we should quickly release a new pypi package
and internal version of TensorBoard so that the graph explorer is not
broken for users of Chrome 62.
Fixes #425. The graph explorer WAI in Chrome 62: