fix: set optional max_instances to default null

Author: apeabody

README.md

@@ -69,7 +69,7 @@ module "localhost_function" {
 | labels | A set of key/value label pairs to assign to the Cloud Function. | `map(string)` | `{}` | no |
 | log\_bucket | Log bucket | `string` | `null` | no |
 | log\_object\_prefix | Log object prefix | `string` | `null` | no |
-| max\_instances | The maximum number of parallel executions of the function. | `number` | `0` | no |
+| max\_instances | The maximum number of parallel executions of the function. | `number` | `null` | no |
 | name | The name to apply to any nameable resources. | `string` | n/a | yes |
 | project\_id | The ID of the project to which resources will be applied. | `string` | n/a | yes |
 | region | The region in which resources will be applied. | `string` | n/a | yes |

modules/repository-function/README.md

@@ -26,6 +26,7 @@ is a tested reference of how to use this submodule with the
 | event\_trigger\_failure\_policy\_retry | A toggle to determine if the function should be retried on failure. | `bool` | `false` | no |
 | ingress\_settings | The ingress settings for the function. Allowed values are ALLOW\_ALL, ALLOW\_INTERNAL\_AND\_GCLB and ALLOW\_INTERNAL\_ONLY. Changes to this field will recreate the cloud function. | `string` | `"ALLOW_ALL"` | no |
 | labels | A set of key/value label pairs to assign to any lableable resources. | `map(string)` | `{}` | no |
+| max\_instances | The maximum number of parallel executions of the function. | `number` | `null` | no |
 | name | The name to apply to any nameable resources. | `string` | n/a | yes |
 | project\_id | The ID of the project to which resources will be applied. | `string` | n/a | yes |
 | region | The region in which resources will be applied. | `string` | n/a | yes |

modules/repository-function/main.tf

@@ -24,6 +24,7 @@ resource "google_cloudfunctions_function" "main" {
   trigger_http                  = var.trigger_http
   vpc_connector_egress_settings = var.vpc_connector_egress_settings
   vpc_connector                 = var.vpc_connector
+  max_instances                 = var.max_instances
 
   dynamic "event_trigger" {
     for_each = var.trigger_http != null ? [] : [1]

modules/repository-function/variables.tf

@@ -127,3 +127,8 @@ variable "timeouts" {
   }
 }
 
+variable "max_instances" {
+  type        = number
+  default     = null
+  description = "The maximum number of parallel executions of the function."
+}

test/setup/versions.tf

@@ -15,13 +15,16 @@
  */
 
 terraform {
-  required_version = ">= 0.12"
-}
-
-provider "google" {
-  version = ">= 3.53.0, < 5.0"
-}
+  required_version = ">= 0.13"
+  required_providers {
 
-provider "google-beta" {
-  version = ">= 3.53.0, < 5.0"
+    google = {
+      source  = "hashicorp/google"
+      version = ">= 3.53.0, < 5.0"
+    }
+    google-beta = {
+      source  = "hashicorp/google-beta"
+      version = ">= 3.53.0, < 5.0"
+    }
+  }
 }

variables.tf

@@ -109,7 +109,7 @@ variable "timeout_s" {
 
 variable "max_instances" {
   type        = number
-  default     = 0
+  default     = null
   description = "The maximum number of parallel executions of the function."
 }