fix: remove gzip content-encoding metadata on function source archive #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthab
changed the title
The gzip content encoding is not right for a zip archive and does not actually work. When working with this module, I had to remove the content-encoding to make things work. Otherwise, I was getting a "End-of-central-directory signature not found" error in Cloud Build during function deployment. When I tried to download the archive using my browser, the browser errored, but gsutil succeeded. The file uploaded to GCS was complete so that was not the reason for the error. Removing the content-encoding field fixed the deployment.
|
/gcbrun |
|
/gcbrun |
apeabody
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gzip content encoding is not right for a zip archive and does not
actually work. When working with this module, I had to remove the
content-encoding to make things work. Otherwise, I was getting a
"End-of-central-directory signature not found" error in Cloud Build
during function deployment.
When I tried to download the archive using my browser, the browser
errored, but gsutil succeeded. The file uploaded to GCS was complete so
that was not the reason for the error. Removing the content-encoding
field fixed the deployment.