feat(TPG >=4.23)!: Add docker_registry variables and use them in google_cloudfunctions_function resource

[tardigrde]

Variables added:

• docker_registry
• docker_repository
• kms_key_name

This enables storing Cloud Build container in Artifact Registry

See https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/cloudfunctions_function#docker_registry

[tardigrde]

Hi! Could you please look at this merge request? I know I created and closed some PRs with the same scope, those were problematic ecause of failing CLAs. Now the commit is with an email address that signed a CLA.

Happy to improve the PR if needed. Let me know if I have to do anything else.

The important thing for me was that I can use Artifact Registry for storing Cloud Build image. I think no default functionality was changed.

Note: I also would like to update https://github.com/terraform-google-modules/terraform-google-scheduled-function with this same functionality.

Can you please run /gcbrun? I think I do not have the rights to do it.

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @tardigrde - Relevant output from the LINT tests:

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/README.md /tmp/tmp.7eUSZEwJ41/generate_docs/workspace/README.md
64c64
< | docker\_repository | User managed repository created in Artifact Registry optionally with a customer managed encryption key. If specified, deployments will use Artifact Registry. | `string` | n/a | yes |
---
> | docker\_repository | User managed repository created in Artifact Registry optionally with a customer managed encryption key. If specified, deployments will use Artifact Registry. | `string` | `""` | no |
71c71
< | kms\_key\_name | Resource name of a KMS crypto key (managed by the user) used to encrypt/decrypt function resources. | `string` | n/a | yes |
---
> | kms\_key\_name | Resource name of a KMS crypto key (managed by the user) used to encrypt/decrypt function resources. | `string` | `""` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
Checking for trailing whitespace
Checking for missing newline at end of file
Error: No newline at end of file ./variables.tf

[tardigrde]

Hey! I fixed the linting problems, can you please do gcbrun again?

See commit: 4ee3f29

[apeabody]

/gcbrun

[tardigrde]

Hi @apeabody ! The checks have been passed, now I tried to updae the branch, but again a gcbrun is needed. Can you please review my changes and merge if no problems found. Thanks!

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @tardigrde!

I've included a few comments below, and additionaly it doesn't appear all these fields are present in TPG 4.11, so https://github.com/terraform-google-modules/terraform-google-event-function/blob/master/versions.tf#L23 will need to be bumped to an appropriate minimum version.

Thanks!

[tardigrde]

Thanks for the heads up! I'm still learning..

Bump google provider min version to v4.23
v4.22 does not have the parameters yet, but v4.23 does have them, see versioned doc: https://registry.terraform.io/providers/hashicorp/google/4.23.0/docs/resources/cloudfunctions_function

[alexrohv]

Ha! I should probably pay closer attention to open PRs. #165 is pretty much a copy of this, as I need this feature as well.

@apeabody @tardigrde Any way we can move it forward?

[apeabody]

/gcbrun

[apeabody]

Ha! I should probably pay closer attention to open PRs. #165 is pretty much a copy of this, as I need this feature as well.

@apeabody @tardigrde Any way we can move it forward?

Triggered the CI

[apeabody]

/gcbrun

[apeabody]

Hi @tardigrde - When you have a chance please run make docker_generate_docs, thanks!

[tardigrde]

Updated! Anything else?

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @tardigrde!

[tardigrde]

@apeabody would you be so kind to make a release? I'd like to get this PR merged too, and for that I need a release in this repo (it's a dependency to scheduled-function module)

[apeabody]

@apeabody would you be so kind to make a release? I'd like to get this PR merged too, and for that I need a release in this repo (it's a dependency to scheduled-function module)

Hi @tardigrde - Sure, please track the release at #167