install -C: also the manage the ignore case

Author: sylvestre

src/uu/install/locales/en-US.ftl

@@ -48,6 +48,9 @@ install-error-missing-file-operand = missing file operand
 install-error-missing-destination-operand = missing destination file operand after '{ $path }'
 install-error-failed-to-remove = Failed to remove existing file { $path }. Error: { $error }
 
+# Warning messages
+install-warning-compare-ignored = the --compare (-C) option is ignored when you specify a mode with non-permission bits
+
 # Verbose output
 install-verbose-creating-directory = creating directory { $path }
 install-verbose-creating-directory-step = install: creating directory { $path }

src/uu/install/locales/fr-FR.ftl

@@ -48,6 +48,9 @@ install-error-missing-file-operand = opérande de fichier manquant
 install-error-missing-destination-operand = opérande de fichier de destination manquant après '{ $path }'
 install-error-failed-to-remove = Échec de la suppression du fichier existant { $path }. Erreur : { $error }
 
+# Messages d'avertissement
+install-warning-compare-ignored = l'option --compare (-C) est ignorée quand un mode est indiqué avec des bits non liés à des droits
+
 # Sortie détaillée
 install-verbose-creating-directory = création du répertoire { $path }
 install-verbose-creating-directory-step = install : création du répertoire { $path }

src/uu/install/src/install.rs

@@ -365,6 +365,15 @@ fn behavior(matches: &ArgMatches) -> UResult<Behavior> {
         return Err(1.into());
     }
 
+    // Check if compare is used with non-permission mode bits
+    if compare && specified_mode.is_some() {
+        let mode = specified_mode.unwrap();
+        let non_permission_bits = 0o7000; // setuid, setgid, sticky bits
+        if mode & non_permission_bits != 0 {
+            show_error!("{}", get_message("install-warning-compare-ignored"));
+        }
+    }
+
     let owner = matches
         .get_one::<String>(OPT_OWNER)
         .map(|s| s.as_str())

tests/by-util/test_install.rs

@@ -2278,3 +2278,50 @@ fn test_selinux_invalid_args() {
         at.remove(&at.plus_as_string(dest));
     }
 }
+
+#[test]
+fn test_install_compare_with_mode_bits() {
+    let test_cases = [
+        ("4755", "setuid bit", true),
+        ("2755", "setgid bit", true),
+        ("1755", "sticky bit", true),
+        ("7755", "setuid + setgid + sticky bits", true),
+        ("755", "permission-only mode", false),
+    ];
+
+    for (mode, description, should_warn) in test_cases {
+        let scene = TestScenario::new(util_name!());
+        let at = &scene.fixtures;
+        let source = format!("source_file_{}", mode);
+        let dest = format!("dest_file_{}", mode);
+
+        at.write(&source, "test content");
+
+        let mode_arg = format!("--mode={}", mode);
+
+        if should_warn {
+            scene.ucmd().args(&["-C", &mode_arg, &source, &dest])
+                .succeeds()
+                .stderr_contains("the --compare (-C) option is ignored when you specify a mode with non-permission bits");
+        } else {
+            scene
+                .ucmd()
+                .args(&["-C", &mode_arg, &source, &dest])
+                .succeeds()
+                .no_stderr();
+
+            // Test second install should be no-op due to -C
+            scene
+                .ucmd()
+                .args(&["-C", &mode_arg, &source, &dest])
+                .succeeds()
+                .no_stderr();
+        }
+
+        assert!(
+            at.file_exists(&dest),
+            "Failed to create dest file for {}",
+            description
+        );
+    }
+}