Skip to content

Commit 98219c8

Browse files
authored
fix: set min-width in form-item content (#9457)
1 parent f8b7b66 commit 98219c8

File tree

5 files changed

+30
-3
lines changed

5 files changed

+30
-3
lines changed

packages/form-layout/src/styles/vaadin-form-item-styles.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ export const formItemStyles = css`
4242
4343
#content {
4444
flex: 1 1 auto;
45+
min-width: 0;
4546
}
4647
4748
#content ::slotted(.full-width) {

packages/form-layout/test/visual/lumo/form-layout-auto-responsive.test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,6 @@ describe('form-layout auto responsive', () => {
123123
await visualDiff(container, 'min-columns-narrow-container');
124124
});
125125

126-
// TODO There is an issue with native inputs not shrinking, leading to
127-
// overflowing items. The baseline image should be updated one this
128-
// issue is fixed.
129126
it('labelsAside', async () => {
130127
element.labelsAside = true;
131128
container.style.width = '800px';

packages/form-layout/test/visual/lumo/form-layout.test.js

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import { nextFrame } from '@vaadin/testing-helpers';
22
import { fixtureSync } from '@vaadin/testing-helpers/dist/fixture.js';
33
import { visualDiff } from '@web/test-runner-visual-regression';
4+
import '@vaadin/text-field';
45
import '@vaadin/vaadin-lumo-styles/props.css';
56
import '@vaadin/vaadin-lumo-styles/components/form-layout.css';
67
import '@vaadin/vaadin-lumo-styles/components/form-item.css';
8+
import '@vaadin/vaadin-lumo-styles/components/text-field.css';
79
import '../../../vaadin-form-layout.js';
810
import '../../../vaadin-form-item.js';
911

@@ -103,6 +105,33 @@ describe('form-layout', () => {
103105
});
104106
});
105107

108+
describe('colspan alignment', () => {
109+
beforeEach(() => {
110+
element = fixtureSync(`
111+
<vaadin-form-layout style="width: 645px; padding-inline: 2em;">
112+
<vaadin-form-item colspan="2">
113+
<label slot="label">Address</label>
114+
<vaadin-text-field class="full-width"></vaadin-text-field>
115+
</vaadin-form-item>
116+
117+
<vaadin-form-item>
118+
<label slot="label">First Name</label>
119+
<vaadin-text-field class="full-width"></vaadin-text-field>
120+
</vaadin-form-item>
121+
122+
<vaadin-form-item>
123+
<label slot="label">Last Name</label>
124+
<vaadin-text-field class="full-width"></vaadin-text-field>
125+
</vaadin-form-item>
126+
</vaadin-form-layout>
127+
`);
128+
});
129+
130+
it('colspan alignment', async () => {
131+
await visualDiff(element, 'colspan-alignment');
132+
});
133+
});
134+
106135
describe('CSS properties', () => {
107136
let div;
108137

6 Bytes
Loading
3.41 KB
Loading

0 commit comments

Comments
 (0)