Skip to content

Commit 205aadd

Browse files
committed
Address review feedback
1 parent bcc6845 commit 205aadd

File tree

1 file changed

+3
-3
lines changed
  • turbopack/crates/turbopack-ecmascript/src/chunk

1 file changed

+3
-3
lines changed

turbopack/crates/turbopack-ecmascript/src/chunk/item.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ impl EcmascriptChunkItemContent {
8888
}
8989

9090
impl EcmascriptChunkItemContent {
91-
async fn module_factory(self: Vc<Self>) -> Result<Vc<Code>> {
91+
async fn module_factory(self: Vc<Self>) -> Result<ResolvedVc<Code>> {
9292
let this = self.await?;
9393
let mut code = CodeBuilder::default();
9494
for additional_id in this.additional_ids.iter().try_join().await? {
@@ -132,7 +132,7 @@ impl EcmascriptChunkItemContent {
132132

133133
code += "})";
134134

135-
Ok(code.build().cell())
135+
Ok(code.build().resolved_cell())
136136
}
137137
}
138138

@@ -229,7 +229,7 @@ async fn module_factory_with_code_generation_issue(
229229
.module_factory()
230230
.await
231231
{
232-
Ok(factory) => factory,
232+
Ok(factory) => *factory,
233233
Err(error) => {
234234
let id = chunk_item.asset_ident().to_string().await;
235235
let id = id.as_ref().map_or_else(|_| "unknown", |id| &**id);

0 commit comments

Comments
 (0)