Drop AssetIdent::new_internal as a turbo task

This gets a relatively low cache hit rate and  we don't believe relying on ResoilvedVc<AssetIdent> for identity is completely reasonable.

Author: lukesandberg

crates/next-api/src/app.rs

@@ -1240,7 +1240,7 @@ impl AppEndpoint {
             {
                 let mut ident = AssetIdent::from_path(project.project_path().owned().await?);
                 ident.add_modifier(rcstr!("client-shared-chunks"));
-                AssetIdent::new(ident)
+                ident.cell()
             },
             this.app_project.client_runtime_entries(),
             *module_graphs.full,
@@ -1810,7 +1810,7 @@ impl AppEndpoint {
                                         this.app_project.project().project_path().owned().await?,
                                     );
                                     ident.add_modifier(rcstr!("server-utils"));
-                                    AssetIdent::new(ident)
+                                    ident.cell()
                                 },
                                 // TODO this should be ChunkGroup::Shared
                                 ChunkGroup::Entry(server_utils),

crates/next-api/src/module_graph.rs

@@ -466,8 +466,8 @@ impl Issue for CssGlobalImportIssue {
 
     #[turbo_tasks::function]
     async fn description(&self) -> Result<Vc<OptionStyledString>> {
-        let parent_path = self.parent_module.ident().path().owned().await?;
-        let module_path = self.module.ident().path().owned().await?;
+        let parent_path = self.parent_module.ident().path().await?;
+        let module_path = self.module.ident().path().await?;
         let relative_import_location = parent_path.parent();
 
         let import_path = match relative_import_location.get_relative_path_to(&module_path) {
@@ -495,8 +495,8 @@ impl Issue for CssGlobalImportIssue {
     }
 
     #[turbo_tasks::function]
-    fn file_path(&self) -> Vc<FileSystemPath> {
-        self.parent_module.ident().path()
+    async fn file_path(&self) -> Result<Vc<FileSystemPath>> {
+        Ok(self.parent_module.ident().path().await?.cell())
     }
 
     #[turbo_tasks::function]

crates/next-api/src/pages.rs

@@ -759,7 +759,7 @@ impl PageEndpoint {
         ) && let Some(chunkable) = Vc::try_resolve_downcast(page_loader).await?
         {
             return Ok(Vc::upcast(HmrEntryModule::new(
-                AssetIdent::new(AssetIdent::from_path(this.page.await?.base_path.clone())),
+                AssetIdent::from_path(this.page.await?.base_path.clone()).cell(),
                 chunkable,
             )));
         }
@@ -859,7 +859,7 @@ impl PageEndpoint {
                 .map(|m| ResolvedVc::upcast(*m))
                 .collect();
             let client_chunk_group = client_chunking_context.evaluated_chunk_group(
-                AssetIdent::new(AssetIdent::from_path(this.page.await?.base_path.clone())),
+                AssetIdent::from_path(this.page.await?.base_path.clone()).cell(),
                 ChunkGroup::Entry(evaluatable_assets),
                 module_graph,
                 AvailabilityInfo::Root,

crates/next-api/src/server_actions.rs

@@ -132,7 +132,7 @@ pub(crate) async fn build_server_actions_loader(
         {
             let mut ident = AssetIdent::from_path(path);
             ident.add_modifier(rcstr!("server actions loader"));
-            AssetIdent::new(ident)
+            ident
         },
         AssetContent::file(file.into()),
     );

crates/next-core/src/base_loader_tree.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use indoc::formatdoc;
 use turbo_rcstr::RcStr;
-use turbo_tasks::{FxIndexMap, ResolvedVc, ValueToString, Vc};
+use turbo_tasks::{FxIndexMap, ResolvedVc, Vc};
 use turbo_tasks_fs::FileSystemPath;
 use turbopack::{ModuleAssetContext, transition::Transition};
 use turbopack_core::{
@@ -115,7 +115,7 @@ impl BaseLoaderTreeBuilder {
         self.inner_assets
             .insert(format!("MODULE_{i}").into(), module);
 
-        let module_path = module.ident().path().to_string().await?;
+        let module_path = module.ident().path().await?.value_to_string().await?;
 
         Ok(format!(
             "[{identifier}, {path}]",

crates/next-core/src/hmr_entry.rs

@@ -29,12 +29,13 @@ use turbopack_ecmascript::{
 /// This produces the 'base' ident for the HMR entry point, which is then modified
 #[turbo_tasks::function]
 async fn hmr_entry_point_base_ident() -> Result<Vc<AssetIdent>> {
-    Ok(AssetIdent::new(AssetIdent::from_path(
+    Ok(AssetIdent::from_path(
         VirtualFileSystem::new_with_name(rcstr!("hmr-entry"))
             .root()
             .await?
             .join("hmr-entry.js")?,
-    )))
+    )
+    .cell())
 }
 
 #[turbo_tasks::value(shared)]
@@ -60,7 +61,7 @@ impl Module for HmrEntryModule {
     async fn ident(&self) -> Result<Vc<AssetIdent>> {
         let mut ident = hmr_entry_point_base_ident().owned().await?;
         ident.add_asset(rcstr!("ENTRY"), self.ident);
-        Ok(AssetIdent::new(ident))
+        Ok(ident.cell())
     }
 
     #[turbo_tasks::function]

crates/next-core/src/next_app/app_client_references_chunks.rs

@@ -4,7 +4,6 @@ use turbo_rcstr::rcstr;
 use turbo_tasks::{FxIndexMap, ResolvedVc, TryFlatJoinIterExt, TryJoinIterExt, Vc};
 use turbopack_core::{
     chunk::{ChunkingContext, availability_info::AvailabilityInfo},
-    ident::AssetIdent,
     module::Module,
     module_graph::{ModuleGraph, chunk_group_info::ChunkGroup},
     output::OutputAssets,
@@ -216,7 +215,7 @@ pub async fn get_app_client_references_chunks(
                             {
                                 let mut ident = (*base_ident).clone();
                                 ident.add_modifier(rcstr!("ssr modules"));
-                                AssetIdent::new(ident)
+                                ident.cell()
                             },
                             ChunkGroup::IsolatedMerged {
                                 parent: parent_chunk_group,
@@ -258,7 +257,7 @@ pub async fn get_app_client_references_chunks(
                         {
                             let mut ident = (*base_ident).clone();
                             ident.add_modifier(rcstr!("client modules"));
-                            AssetIdent::new(ident)
+                            ident.cell()
                         },
                         ChunkGroup::IsolatedMerged {
                             parent: parent_chunk_group,

crates/next-core/src/next_app/app_page_entry.rs

@@ -8,7 +8,6 @@ use turbopack::ModuleAssetContext;
 use turbopack_core::{
     asset::{Asset, AssetContent},
     context::AssetContext,
-    ident::AssetIdent,
     module::Module,
     reference_type::ReferenceType,
     source::Source,
@@ -107,8 +106,7 @@ pub async fn get_app_page_entry(
     let file = File::from(result.build());
     let mut ident = source.ident().owned().await?;
     ident.query = RcStr::from(format!("?{query}"));
-    let source =
-        VirtualSource::new_with_ident(AssetIdent::new(ident), AssetContent::file(file.into()));
+    let source = VirtualSource::new_with_ident(ident, AssetContent::file(file.into()));
 
     let mut rsc_entry = module_asset_context
         .process(

crates/next-core/src/next_app/app_route_entry.rs

@@ -55,7 +55,7 @@ pub async fn get_app_route_entry(
     let original_name: RcStr = page.to_string().into();
     let pathname: RcStr = AppPath::from(page.clone()).to_string().into();
 
-    let path = source.ident().path().owned().await?;
+    let path = source.ident().path().await?;
 
     let inner = rcstr!("INNER_APP_ROUTE");
 

crates/next-core/src/next_client_reference/css_client_reference/css_client_reference_module.rs

@@ -37,7 +37,7 @@ impl Module for CssClientReferenceModule {
     async fn ident(&self) -> Result<Vc<AssetIdent>> {
         let mut ident = self.client_module.ident().owned().await?;
         ident.add_modifier(rcstr!("css client reference"));
-        Ok(AssetIdent::new(ident))
+        Ok(ident.cell())
     }
 
     #[turbo_tasks::function]