Remove a layzer of indirction from cell access

Author: lukesandberg

turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs

@@ -37,7 +37,7 @@ pub trait Operation:
     + TryFrom<AnyOperation, Error = ()>
     + Into<AnyOperation>
 {
-    fn execute(self, ctx: &mut impl ExecuteContext);
+    fn execute(self, ctx: &mut impl ExecuteContext<'_>);
 }
 
 #[derive(Copy, Clone)]
@@ -579,7 +579,7 @@ pub enum AnyOperation {
 }
 
 impl AnyOperation {
-    pub fn execute(self, ctx: &mut impl ExecuteContext) {
+    pub fn execute(self, ctx: &mut impl ExecuteContext<'_>) {
         match self {
             AnyOperation::ConnectChild(op) => op.execute(ctx),
             AnyOperation::Invalidate(op) => op.execute(ctx),

turbopack/crates/turbo-tasks-backend/src/backend/operation/update_output.rs

@@ -46,7 +46,7 @@ impl UpdateOutputOperation {
     pub fn run(
         task_id: TaskId,
         output: Result<RawVc, TurboTasksExecutionError>,
-        mut ctx: impl ExecuteContext,
+        mut ctx: impl ExecuteContext<'_>,
     ) {
         let mut dependent_tasks = Default::default();
         let mut children = Default::default();
@@ -140,7 +140,7 @@ impl UpdateOutputOperation {
 }
 
 impl Operation for UpdateOutputOperation {
-    fn execute(mut self, ctx: &mut impl ExecuteContext) {
+    fn execute(mut self, ctx: &mut impl ExecuteContext<'_>) {
         loop {
             ctx.operation_suspend_point(&self);
             match self {

turbopack/crates/turbo-tasks-backend/src/backend/storage.rs

@@ -612,7 +612,7 @@ enum ModifiedState {
 pub struct Storage {
     snapshot_mode: AtomicBool,
     modified: FxDashMap<TaskId, ModifiedState>,
-    map: FxDashMap<TaskId, Box<InnerStorage>>,
+    map: FxDashMap<TaskId, InnerStorage>,
 }
 
 impl Storage {
@@ -786,7 +786,7 @@ impl Storage {
     pub fn access_mut(&self, key: TaskId) -> StorageWriteGuard<'_> {
         let inner = match self.map.entry(key) {
             dashmap::mapref::entry::Entry::Occupied(e) => e.into_ref(),
-            dashmap::mapref::entry::Entry::Vacant(e) => e.insert(Box::new(InnerStorage::new())),
+            dashmap::mapref::entry::Entry::Vacant(e) => e.insert(InnerStorage::new()),
         };
         StorageWriteGuard {
             storage: self,
@@ -799,7 +799,7 @@ impl Storage {
         key1: TaskId,
         key2: TaskId,
     ) -> (StorageWriteGuard<'_>, StorageWriteGuard<'_>) {
-        let (a, b) = get_multiple_mut(&self.map, key1, key2, || Box::new(InnerStorage::new()));
+        let (a, b) = get_multiple_mut(&self.map, key1, key2, || InnerStorage::new());
         (
             StorageWriteGuard {
                 storage: self,
@@ -820,7 +820,7 @@ impl Storage {
 
 pub struct StorageWriteGuard<'a> {
     storage: &'a Storage,
-    inner: RefMut<'a, TaskId, Box<InnerStorage>>,
+    inner: RefMut<'a, TaskId, InnerStorage>,
 }
 
 impl StorageWriteGuard<'_> {
@@ -873,7 +873,7 @@ impl StorageWriteGuard<'_> {
                     if !state.any_snapshot() {
                         self.storage.modified.insert(
                             *self.inner.key(),
-                            ModifiedState::Snapshot(Some(Box::new((&**self.inner).into()))),
+                            ModifiedState::Snapshot(Some(Box::new((&*self.inner).into()))),
                         );
                     }
                     let state = self.inner.state_mut();